Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump WooCommerce "tested up to" version 9.1 #178

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Bump WooCommerce "tested up to" version 9.1 #178

merged 3 commits into from
Aug 2, 2024

Conversation

qasumitbagthariya
Copy link
Contributor

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

Closes #171

Steps to test the changes in this Pull Request:

  1. Run the e2e test using GitHub action to test compatibility
  2. All tests should be passed.

Changelog entry

Dev - Bump WooCommerce "tested up to" version 9.1.
Dev - Bump WooCommerce minimum supported version to 8.9.

@qasumitbagthariya qasumitbagthariya linked an issue Jul 16, 2024 that may be closed by this pull request
Compatibility testing with Woo 9.1 #171
Closed
11 tasks
@qasumitbagthariya qasumitbagthariya self-assigned this Jul 16, 2024
@dkotter
Copy link
Contributor

dkotter commented Jul 16, 2024

E2E tests are failing here. Not sure if related to Woo 9.1 or not but need to investigate that

@iamdharmesh
Copy link
Member

E2E tests are failing here. Not sure if related to Woo 9.1 or not but need to investigate that

I have noticed these 2 tests failing on multiple PRs and they pass on retry. So, these 2 tests are flaky and need to be fixed.

@iamdharmesh
Copy link
Member

@dkotter I have fixed flaky tests, tried running in local multiple times, and ran on GH action 2 times and it seems working fine now. Will keep an eye on it once this PR is merged.

@qasumitbagthariya
Copy link
Contributor Author

Regression / Smoke Test Report ✅

Tested with Archive File created via "php woorelease.phar build repo_URL" (Composer version 2.5.5, npm version 8.19.4, node version 16.20.0)

Status- Working expected with Plugin Archive/Zip file same as fix specific branch.

Next Step- Ready to Merge 🚀

@vikrampm1 vikrampm1 added this to the 4.7.3 milestone Aug 2, 2024
@vikrampm1 vikrampm1 marked this pull request as ready for review August 2, 2024 14:49
@vikrampm1 vikrampm1 merged commit dfd60e7 into trunk Aug 2, 2024
6 checks passed
@vikrampm1 vikrampm1 deleted the comp-woo-9.1 branch August 2, 2024 14:49
@vikrampm1 vikrampm1 mentioned this pull request Aug 2, 2024
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

Assignees

@qasumitbagthariya qasumitbagthariya

Labels
needs: e2e testing
Projects
None yet
Milestone
4.7.3
Development

Successfully merging this pull request may close these issues.

Compatibility testing with Woo 9.1
4 participants
@qasumitbagthariya @dkotter @iamdharmesh @vikrampm1