Skip to content

Commit

Permalink
Fixing an unwanted page refresh when using Woo Navigation (woocommerc…
Browse files Browse the repository at this point in the history
…e/woocommerce-admin#7615)

* Adding changelog

* Fixing page refresh on woo navigation

* Narrowing scope of navigation slot fills
  • Loading branch information
joelclimbsthings committed Sep 15, 2021
1 parent 3b34725 commit 3ee60dc
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 14 deletions.
4 changes: 4 additions & 0 deletions plugins/woocommerce-admin/changelogs/fix-woonav-page-refresh
@@ -0,0 +1,4 @@
Significance: patch
Type: Fix

Fixing an unwanted page refresh when using Woo Navigation
3 changes: 3 additions & 0 deletions plugins/woocommerce-admin/client/layout/index.js
Expand Up @@ -174,6 +174,9 @@ class _Layout extends Component {
) }
</div>
<PluginArea scope="woocommerce-admin" />
{ window.wcAdminFeatures.navigation && (
<PluginArea scope="woocommerce-navigation" />
) }
</SlotFillProvider>
);
}
Expand Down
1 change: 1 addition & 0 deletions plugins/woocommerce-admin/client/layout/navigation.js
Expand Up @@ -93,4 +93,5 @@ const NavigationPlugin = () => {

registerPlugin( 'wc-admin-navigation', {
render: NavigationPlugin,
scope: 'woocommerce-navigation',
} );
Expand Up @@ -3,21 +3,24 @@
*/
import { __ } from '@wordpress/i18n';
import { Button } from '@wordpress/components';
import { registerPlugin } from "@wordpress/plugins";
import { WooNavigationItem } from "@woocommerce/navigation";
import { registerPlugin } from '@wordpress/plugins';
import { WooNavigationItem } from '@woocommerce/navigation';

const MyPlugin = () => {
const handleClick = () => {
alert( 'Menu item clicked!' );
}
const handleClick = () => {
alert( 'Menu item clicked!' );
};

return (
<WooNavigationItem item="example-category-child-2">
<Button onClick={ handleClick }>
{ __( 'JavaScript Example', 'plugin-domain' ) }
</Button>
</WooNavigationItem>
);
return (
<WooNavigationItem item="example-category-child-2">
<Button onClick={ handleClick }>
{ __( 'JavaScript Example', 'plugin-domain' ) }
</Button>
</WooNavigationItem>
);
};

registerPlugin('my-plugin', { render: MyPlugin });
registerPlugin( 'my-plugin', {
render: MyPlugin,
scope: 'woocommerce-navigation',
} );
2 changes: 1 addition & 1 deletion plugins/woocommerce-admin/docs/features/navigation.md
Expand Up @@ -121,5 +121,5 @@ const MyPlugin = () => {
);
};

registerPlugin('my-plugin', { render: MyPlugin });
registerPlugin( 'my-plugin', { render: MyPlugin, scope: 'woocommerce-navigation' } );
```

0 comments on commit 3ee60dc

Please sign in to comment.