Skip to content

Commit

Permalink
Update/39325 typo in core profiler data sharing copy (#39327)
Browse files Browse the repository at this point in the history 
* Fix grammar in data-sharing agreement copy

* Add changelog

* Put ,

* Add brackets

* Move learn more link inside the bracket

* Update test snapshot

* Fix grammar

* Update test snapshot
  • Loading branch information
@moon0326 @tommyshellberg
moon0326 authored and tommyshellberg committed Aug 7, 2023
1 parent 0b2f37d commit 6dfb459
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 19 deletions.
2 changes: 1 addition & 1 deletion plugins/woocommerce-admin/client/core-profiler/pages/IntroOptIn.tsx
View file
Expand Up @@ -71,7 +71,7 @@ export const IntroOptIn = ( {
className="core-profiler__checkbox"
label={ interpolateComponents( {
mixedString: __(
'I agree to share my data to tailor my store setup experience and get more relevant content. WooCommerce never rent or sell your data and you can opt out at any time in WooCommerce settings. {{link}}Learn more about usage tracking{{/link}}.',
'I agree to share my data to tailor my store setup experience and get more relevant content (WooCommerce will never rent or sell your data, and you can opt out at any time in WooCommerce settings. {{link}}Learn more about usage tracking.{{/link}})',
'woocommerce'
),
components: {
Expand Down
36 changes: 18 additions & 18 deletions ...ommerce-admin/client/core-profiler/test/__snapshots__/core-profiler-machine.test.tsx.snap
View file
Expand Up @@ -451,15 +451,15 @@ Object {
class="components-checkbox-control__label"
for="inspector-checkbox-control-1"
>
I agree to share my data to tailor my store setup experience and get more relevant content. WooCommerce never rent or sell your data and you can opt out at any time in WooCommerce settings.
I agree to share my data to tailor my store setup experience and get more relevant content (WooCommerce will never rent or sell your data, and you can opt out at any time in WooCommerce settings.
<a
data-link-type="external"
href="https://woocommerce.com/usage-tracking?utm_medium=product"
target="_blank"
>
Learn more about usage tracking
Learn more about usage tracking.
</a>
.
)
</label>
</div>
</div>
Expand Down Expand Up @@ -596,15 +596,15 @@ Object {
class="components-checkbox-control__label"
for="inspector-checkbox-control-1"
>
I agree to share my data to tailor my store setup experience and get more relevant content. WooCommerce never rent or sell your data and you can opt out at any time in WooCommerce settings.
I agree to share my data to tailor my store setup experience and get more relevant content (WooCommerce will never rent or sell your data, and you can opt out at any time in WooCommerce settings.
<a
data-link-type="external"
href="https://woocommerce.com/usage-tracking?utm_medium=product"
target="_blank"
>
Learn more about usage tracking
Learn more about usage tracking.
</a>
.
)
</label>
</div>
</div>
Expand Down Expand Up @@ -971,15 +971,15 @@ Object {
class="components-checkbox-control__label"
for="inspector-checkbox-control-3"
>
I agree to share my data to tailor my store setup experience and get more relevant content. WooCommerce never rent or sell your data and you can opt out at any time in WooCommerce settings.
I agree to share my data to tailor my store setup experience and get more relevant content (WooCommerce will never rent or sell your data, and you can opt out at any time in WooCommerce settings.
<a
data-link-type="external"
href="https://woocommerce.com/usage-tracking?utm_medium=product"
target="_blank"
>
Learn more about usage tracking
Learn more about usage tracking.
</a>
.
)
</label>
</div>
</div>
Expand Down Expand Up @@ -1116,15 +1116,15 @@ Object {
class="components-checkbox-control__label"
for="inspector-checkbox-control-3"
>
I agree to share my data to tailor my store setup experience and get more relevant content. WooCommerce never rent or sell your data and you can opt out at any time in WooCommerce settings.
I agree to share my data to tailor my store setup experience and get more relevant content (WooCommerce will never rent or sell your data, and you can opt out at any time in WooCommerce settings.
<a
data-link-type="external"
href="https://woocommerce.com/usage-tracking?utm_medium=product"
target="_blank"
>
Learn more about usage tracking
Learn more about usage tracking.
</a>
.
)
</label>
</div>
</div>
Expand Down Expand Up @@ -1878,15 +1878,15 @@ Object {
class="components-checkbox-control__label"
for="inspector-checkbox-control-2"
>
I agree to share my data to tailor my store setup experience and get more relevant content. WooCommerce never rent or sell your data and you can opt out at any time in WooCommerce settings.
I agree to share my data to tailor my store setup experience and get more relevant content (WooCommerce will never rent or sell your data, and you can opt out at any time in WooCommerce settings.
<a
data-link-type="external"
href="https://woocommerce.com/usage-tracking?utm_medium=product"
target="_blank"
>
Learn more about usage tracking
Learn more about usage tracking.
</a>
.
)
</label>
</div>
</div>
Expand Down Expand Up @@ -2023,15 +2023,15 @@ Object {
class="components-checkbox-control__label"
for="inspector-checkbox-control-2"
>
I agree to share my data to tailor my store setup experience and get more relevant content. WooCommerce never rent or sell your data and you can opt out at any time in WooCommerce settings.
I agree to share my data to tailor my store setup experience and get more relevant content (WooCommerce will never rent or sell your data, and you can opt out at any time in WooCommerce settings.
<a
data-link-type="external"
href="https://woocommerce.com/usage-tracking?utm_medium=product"
target="_blank"
>
Learn more about usage tracking
Learn more about usage tracking.
</a>
.
)
</label>
</div>
</div>
Expand Down
4 changes: 4 additions & 0 deletions plugins/woocommerce/changelog/update-39325-typo-in-core-profiler-data-sharing-copy
View file
@@ -0,0 +1,4 @@
Significance: minor
Type: update

Fix grammar in data-sharing agreement copy

0 comments on commit 6dfb459

Please sign in to comment.