Skip to content

Commit

Permalink
Test
Browse files Browse the repository at this point in the history
  • Loading branch information
Aljullu committed Apr 11, 2024
1 parent c1b7b14 commit 7680f50
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 6 deletions.
12 changes: 6 additions & 6 deletions plugins/woocommerce-blocks/tests/e2e/global-setup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ const prepareAttributes = async () => {
// It doesn't seem to be working correctly ATM so we need to do it via
// browser actions.
// See: https://github.com/woocommerce/woocommerce/issues/32831
await page
.getByRole( 'row', {
name: /Regenerate the product attributes lookup table/,
} )
.getByRole( 'button' )
.click();
// await page
// .getByRole( 'row', {
// name: /Regenerate the product attributes lookup table/,
// } )
// .getByRole( 'button' )
// .click();

await page.goto( BASE_URL + '/wp-admin/post-new.php' );

Expand Down
8 changes: 8 additions & 0 deletions plugins/woocommerce/src/Blocks/BlockTemplatesController.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@

use Automattic\WooCommerce\Blocks\Utils\BlockTemplateUtils;

// TODO:
// --- There are two references that might help:
// ----- AbstractPageTemplate hooks into `page_template_hierarchy`. Might it be helpful?
// ----- Alba's PR has a `add_archive_product_to_hierarchy` function which might be useful? https://github.com/woocommerce/woocommerce-blocks/pull/7764/files#diff-8ae3c446b897aa3d87c4814f390b6809b5af8cbf0e29180adb945afe6dfd6445R110
// - What to do with Products by Attribute template considering each attribute is its own taxonomy: https://github.com/WordPress/gutenberg/pull/46270
// - Product Search Results shouldn't fall back to archive-product.
// - Update e2e tests.

/**
* BlockTypesController class.
*
Expand Down

0 comments on commit 7680f50

Please sign in to comment.