-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update product editor CES modal to match new designs (#38592)
* Add new fields and copy update to product CES modal * Update styling for product CES modal * Record email in tracks callback if provided * Fix modal header spacing * Fix record callback types * Add optional tag styling * Allow submitting form when a reason has been selected * Fix modal padding bottom * Update modal width to match designs * Add changelog entries * Update margin for legend * Add props to doc comment * Make className prop optional * Update tests for recording score with email
- Loading branch information
Showing
7 changed files
with
158 additions
and
72 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: minor | ||
Type: add | ||
|
||
Add props to allow passing a classname to the feedback modal |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: minor | ||
Type: update | ||
|
||
Update product CES modal design and fields |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 47 additions & 8 deletions
55
packages/js/product-editor/src/components/product-mvp-feedback-modal/style.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,62 @@ | ||
$modal-header-height: 84px; | ||
|
||
.woocommerce-product-mvp-feedback-modal { | ||
width: 600px; | ||
|
||
.components-modal__header { | ||
height: $modal-header-height; | ||
|
||
&-heading { | ||
font-weight: 500; | ||
font-size: 20px; | ||
} | ||
} | ||
|
||
.components-modal__content { | ||
margin-top: $modal-header-height; | ||
padding-bottom: 32px; | ||
} | ||
|
||
legend, | ||
label { | ||
color: $gray-900; | ||
} | ||
|
||
.woocommerce-product-mvp-feedback-modal__optional { | ||
color: $gray-700; | ||
} | ||
|
||
legend { | ||
font-size: 11px; | ||
font-weight: 500; | ||
line-height: 1.4; | ||
text-transform: uppercase; | ||
display: inline-block; | ||
margin-bottom: $gap-small; | ||
padding: 0; | ||
} | ||
|
||
&__subtitle { | ||
margin-top: $gap-smaller !important; | ||
} | ||
|
||
&__checkboxes { | ||
margin: $gap-small 0; | ||
display: grid; | ||
grid-template-columns: 1fr 1fr; | ||
} | ||
|
||
&__comments { | ||
margin-top: 2em; | ||
margin-bottom: 1.5em; | ||
|
||
label { | ||
display: block; | ||
font-weight: bold; | ||
text-transform: none; | ||
font-size: 14px; | ||
} | ||
|
||
textarea { | ||
width: 100%; | ||
} | ||
} | ||
|
||
&__reason, | ||
&__comments, | ||
&__email { | ||
margin-bottom: $gap-large; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters