Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n in slugs #1867

Closed
kix opened this issue Nov 28, 2012 · 2 comments
Closed

I18n in slugs #1867

kix opened this issue Nov 28, 2012 · 2 comments

Comments

@kix
Copy link

kix commented Nov 28, 2012

In woocommerce/woocommerce.php:648 the product-category global slug goes through i18n, which means that once I change the locale in my configuration, the old page slugs are still effective yet the paths generated afterwards are incorrect.
Perhaps there shouldn't be any i18n in the routing?

@lkraav
Copy link
Contributor

lkraav commented Nov 28, 2012

I also experienced severe wonkyness with core slugs in combination with WPML. Solution was to force-translate other language to use core english slugs. Not sure if this applies entirely, but I'm definitely going to watch here.

@coenjacobs
Copy link
Contributor

For the DD release we have been working with the developers of WPML (ticket ref: #1579). The changes that we've pushed referenced in that ticket are done to ensure it all works fine. WPML is able to change the static slug (now moved to Permalink settings btw) that you can set for products, for different languages as done here: e159952 So this is issue will be resolved when DD rolls out our factory and WPML releases a new compatible WPML version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants