Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordpress Update 5.02 broke the orders tab #22271

Closed
poly-media opened this issue Dec 20, 2018 · 30 comments · Fixed by #22273
Closed

Wordpress Update 5.02 broke the orders tab #22271

poly-media opened this issue Dec 20, 2018 · 30 comments · Fixed by #22273
Assignees
Labels
type: bug The issue is a confirmed bug.
Milestone

Comments

@poly-media
Copy link

poly-media commented Dec 20, 2018

hey,
one of my sites auto updated to 5.02 this night and the orders tab (only the all tab) is not showing any orders. Was working fine before update. Running latest woocommerce & wordpress.

Seems like more people having the same issue: https://woocommerce.com/posts/woocommerce-and-wordpress-5-0/
(comment: "Daniel Ellis
December 20, 2018 at 4:22 am #
Hi
The website update to 5.02
And in woocomnerce orders
All orders is blank and tab called mine is blank some if the others still appears to be there , I think a technical problem needing updating fast
I have 2 others with same issue all ready")

screenshot

@adelineyaw
Copy link

Issue seen via chat 8942288-hc (follow up via 1658282-zen)

@orhanfernandes
Copy link

Issue seen via chat 8943986-hc (followed up via 1658327-zen) and 8943726-hc

@giairlanda
Copy link

Hello, I've same problem. So how to fix it?
tes23

@orhanfernandes
Copy link

Issue seen via 7596898-hc

@cmbaldwin
Copy link

Seconding this as well, also happening on my instance (in Japanese). On the "processing" tab, and other specific order type exploration tabs, it shows up.
screenshot_2018-12-20 funabiki online wordpress

@SiR-DanieL
Copy link
Member

SiR-DanieL commented Dec 20, 2018

More at 8945012-hc and 8118451-hc

@AashikP
Copy link
Collaborator

AashikP commented Dec 20, 2018

Also reported in

  • 5309012-hc. Follow-up at 1658433-zen
  • 8945595-hc. Follow-up at 1658433-zen

@tamarazuk
Copy link
Contributor

I've run across this on several merchant sites as well. Confirmed locally that the issue appears right after updating WP to 5.0.2. Filtering by individual statuses does allow me to view orders however.

@pento
Copy link

pento commented Dec 20, 2018

Here's a workaround for this issue, which you can use until a fix is released:

function fix_request_query_args_for_woocommerce( $query_args ) {
	if ( isset( $query_args['post_status'] ) && empty( $query_args['post_status'] ) ) {
		unset( $query_args['post_status'] );
	}
	return $query_args;
}
add_filter( 'request', 'fix_request_query_args_for_woocommerce', 1, 1 );

@davidcommarmond
Copy link

davidcommarmond commented Dec 20, 2018

Thanks @pento
Maybe check the current version first, so it only applies to woocommerce <= 3.5.2 and wordpress 5.0.2, as they'll surely provide a fix in future versions.

if(version_compare(get_option( 'woocommerce_version' ),"3.5.2","<=") && version_compare(get_bloginfo( 'version' ),"5.0.2","=") ){
    function fix_request_query_args_for_woocommerce( $query_args ) {
    	if ( isset( $query_args['post_status'] ) && empty( $query_args['post_status'] ) ) {
    		unset( $query_args['post_status'] );
    	}
    	return $query_args;
    }
    add_filter( 'request', 'fix_request_query_args_for_woocommerce', 1, 1 );
}

@rohittm
Copy link

rohittm commented Dec 20, 2018

The issue also is seen in:

8945739-hc.
8949178-hc

@dougaitken
Copy link
Member

dougaitken commented Dec 20, 2018

Adding any of my interactions here:
8946131-hc
1658565-zen
1658582-zen
1658561-zen

@whitetornado
Copy link

where to add or change?? facing the same issue

@SiR-DanieL
Copy link
Member

@whitetornado you need to add the code in wp-content/themes/your-child-theme-name/functions.php at the end of the file.

@amirhoseindavat
Copy link

Here's a workaround for this issue, which you can use until a fix is released:

function fix_request_query_args_for_woocommerce( $query_args ) {
	if ( isset( $query_args['post_status'] ) && empty( $query_args['post_status'] ) ) {
		unset( $query_args['post_status'] );
	}
	return $query_args;
}
add_filter( 'request', 'fix_request_query_args_for_woocommerce', 1, 1 );

Thank you man 👍🏻

@vietanhdev
Copy link

image
It also happened with my site.

@donalirl
Copy link

Another #8406393-hc

@liviopv
Copy link

liviopv commented Dec 20, 2018

1658809-zen

@rodrigoprimo rodrigoprimo added the type: bug The issue is a confirmed bug. label Dec 20, 2018
@rodrigoprimo rodrigoprimo added this to the 3.5.3 milestone Dec 20, 2018
@rodrigoprimo rodrigoprimo self-assigned this Dec 20, 2018
@rrennick rrennick mentioned this issue Dec 20, 2018
3 tasks
@rodrigoprimo
Copy link
Contributor

See PR #22273. It would be great if we could get some people to test it as we plan to release a new version of WC as soon as possible.

@JohnnyXP64
Copy link

JohnnyXP64 commented Dec 20, 2018

any possible release time for this guys?
thanks for the workarround with this plugin and the above new function,, works for now (safly without touching actual wc source files)
https://wordpress.org/plugins/my-custom-functions/

@vimes1984
Copy link

I'm experincing this problem aswell guys +1 on a fix

@franckadil
Copy link

franckadil commented Dec 20, 2018

Solved on WooCommerce 3.5.3.

Hi,

Thanks to Pento and David Commarmond

We have crafted a plugin that fixes the issue, while waiting for a solution from the devs at WooCommerce 🙂

Here is the plugin:
https://github.com/junglewp/WooFix

WordPress Peace Keepers

@fernandotellado
Copy link

The new released version 3.5.3 claim to solve the orders issue but breaks the block editor too :(

The error copied is this one:

TypeError: Cannot read property 'select' of undefined at https://testu.sgedu.site/wp-includes/js/dist/editor.min.js:55:271508 at n.value (https://testu.sgedu.site/wp-includes/js/dist/data.min.js:1:14919) at new n (https://testu.sgedu.site/wp-includes/js/dist/data.min.js:1:14614) at zf (https://testu.sgedu.site/wp-includes/js/dist/vendor/react-dom.min.js:69:258) at Mf (https://testu.sgedu.site/wp-includes/js/dist/vendor/react-dom.min.js:87:4) at ph (https://testu.sgedu.site/wp-includes/js/dist/vendor/react-dom.min.js:98:474) at eg (https://testu.sgedu.site/wp-includes/js/dist/vendor/react-dom.min.js:125:307) at fg (https://testu.sgedu.site/wp-includes/js/dist/vendor/react-dom.min.js:126:168) at wc (https://testu.sgedu.site/wp-includes/js/dist/vendor/react-dom.min.js:138:237) at fa (https://testu.sgedu.site/wp-includes/js/dist/vendor/react-dom.min.js:137:115)

@rodrigoprimo
Copy link
Contributor

@fernandotellado, if you believe this problem is caused by WooCommerce core, could you please open another issue using the bug report template providing all the details to reproduce the issue? On a first look, this seems unrelated to the 3.5.3 fix, but we don't have enough information to be sure. I quickly tested editing posts and pages in my local environment, and the block editor is working.

@fernandotellado
Copy link

Done!

#22279

@letsallhelp
Copy link

Hi gang, Just jumping in here. WooCommerce just released an updated that fixed the order display issue however if your also have WooCommerce Subscriptions like I do the error is still there - Guessing they missed this??

@ProMarpe
Copy link

Hi I updated to Wordpress 5.0.2 recently and as we know, orders disappeared. Woocommerce came out with an update to 3.5.3 and I did that, only weird thing is all of my December orders are missing now. I tried de-activating plugins and activating them again one by one but to no avail. Anyone knows the reason why?

@makeonlineshop
Copy link

Hello,
Can you please tell me how to avoid this problem ?
I haven't updated anything yet as it is so clear that new (often useless) updates always bring problems.
Thank you.

@webthread
Copy link

Seems this issue still happens with WC Subscriptions activated. Seems a long time to leave things as it's now April.

@rodrigoprimo
Copy link
Contributor

@webthread, this issue tracker is used exclusively for WooCommerce core. If you believe the problem you are experiencing is related to core, could you please open another issue detailing the steps to reproduce it? If instead, you believe the problem is caused by WooCommerce Subscriptions, please contact Woocommerce.com support: http://woocommerce.com/contact-us/

@mombrea
Copy link

mombrea commented Apr 16, 2019

@davidcommarmond just came across this myself, one minor update to the version check since the latest version of WordPress has increased to make it >= :

if(version_compare(get_option( 'woocommerce_version' ),"3.5.2","<=") && version_compare(get_bloginfo( 'version' ),"5.0.2",">=") ){
    function fix_request_query_args_for_woocommerce( $query_args ) {
        if ( isset( $query_args['post_status'] ) && empty( $query_args['post_status'] ) ) {
                unset( $query_args['post_status'] );
        }
        return $query_args;
    }
    add_filter( 'request', 'fix_request_query_args_for_woocommerce', 1, 1 );
}

@woocommerce woocommerce locked as resolved and limited conversation to collaborators Apr 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.