Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why depend on jQuery UI on the front end? #298

Closed
dominic-p opened this issue Nov 30, 2011 · 6 comments
Closed

Why depend on jQuery UI on the front end? #298

dominic-p opened this issue Nov 30, 2011 · 6 comments

Comments

@dominic-p
Copy link
Contributor

This isn't so much an issue as a question. I'm trying to streamline the performance of my site as much as possible, and I noticed that WooCommerce depends on jQuery UI which is a pretty hefty plugin. Could someone let me know what UI is used for on the front end?
@mikejolley
Copy link
Member

The price slider.

@dominic-p
Copy link
Contributor Author

Thanks for the super quick reply. Ok, so if I'm not planning on using that feature, I should be able to safely prevent the script from loading by putting something like wp_deregister_script( 'woocommerce_plugins' ); in my functions.php?

@mikejolley
Copy link
Member

No - if you look in the JS file you'll see there are several scripts minified together. Looking at JS optimisations in the next release.

@dominic-p
Copy link
Contributor Author

Ok, yeah, I just tried to disable the script, and I had a lot of other JS issues crop up. I personally would love to see a check box on the main settings page to enable or disable jQuery UI (and the corresponding widgets?) like you guys did for the WooCommerce Lightbox.

@mikejolley
Copy link
Member

Thats an option. Maybe a more basic pair of fields as a fallback for min/max price.

@dominic-p
Copy link
Contributor Author

Yeah, that would be great. That way, you don't lose any real functionality if you don't want to use UI.

@publifiedlabs publifiedlabs mentioned this issue Jul 1, 2017
Closed
8 tasks
@Wikomac Wikomac mentioned this issue Jan 29, 2018
Closed
1 task
@nigeljamesstevenson nigeljamesstevenson mentioned this issue Feb 15, 2024
Merged
11 tasks
nigeljamesstevenson added a commit that referenced this issue Feb 15, 2024
@nigeljamesstevenson @lsinger
Cherry-pick #298 into trunk (#44666)
45fd1ab 
* add wc_get_valid_product_statuses

* add support for sku

* add unit tests for the `product_page` shortcode

* add `woocommerce_shortcode_product_page_override_read_permissions_unpublished` filter

* keep a list of invalid statuses instead of valid ones and allow overriding it

* move deprecation notice handling into methods

* appease the linter

* remove `visibility` attribute

* ensure we remove the filters that we add in a test

* allow overriding read permissions in both directions (or not at all)

* add sku-based tests and remove some superfluous testing data and asserts

* add back in missing variable

* remove superfluous `hidden` visibilities

* add changelog file

---------

Co-authored-by: Leif Singer <git@singer.sh>
@alvarothomas alvarothomas mentioned this issue Feb 16, 2024
Merged
11 tasks
nigeljamesstevenson pushed a commit that referenced this issue Feb 21, 2024
@alvarothomas @lsinger
Cherry-pick #298 into release/8.7.0.10 (#44708)
6df2214 
* add wc_get_valid_product_statuses

* add support for sku

* add unit tests for the `product_page` shortcode

* add `woocommerce_shortcode_product_page_override_read_permissions_unpublished` filter

* keep a list of invalid statuses instead of valid ones and allow overriding it

* move deprecation notice handling into methods

* appease the linter

* remove `visibility` attribute

* ensure we remove the filters that we add in a test

* allow overriding read permissions in both directions (or not at all)

* add sku-based tests and remove some superfluous testing data and asserts

* add back in missing variable

* remove superfluous `hidden` visibilities

* add changelog file

---------

Co-authored-by: Leif Singer <git@singer.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikejolley @dominic-p