New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Customize your deposit schedule" #34698
Comments
I had the exact same issue. 🤬 |
The above fix is not working for me. This message is unwanted and is taking up valuable word space on every Woocommerce page. |
Agree it does take up space & no one wants to see it. sorry that it didnt work for you & it may even come back tomorrow on my shop. Can only but try things till a fix is found |
A very unwelcome addition to WooCommerce. |
Thanks for the report -- something seems to have gone haywire with our Inbox messaging system, and we're working on figuring out a fix. In the mean time this message should have been disabled for now (although should not have displayed like this in the first place). It's possible you can still see it if it's cached locally. |
Another report in 5558603-zen. Clearing cache fixed the issue now. |
Another report 36962997-hc |
I have tried everything suggested above and it's still there. |
To be clear, clicking the link and clearing the cache did not eliminate it. I even tried opening it in a browser I haven't used in a long time, and it was there. So definitely not fixed as of 1:15 PM ET on Sept. 16th. I agree with everyone, this is distracting and annoying when you're trying to get your work done. |
This should be resolved now (for new sites/sites which haven't seen it yet), but if your site has previously/already downloaded the note, you may want to force-refresh the cached message objects. If you don't force-refresh, it will take up to 24 hours to get the updated message objects, so you'll unfortunately continue to see this message in that time. To force-refresh the cache, you would need to do something like;
|
Hi, @webdados! I hope the issue is resolved for you.
In regards to this, I just want to clarify that the portion of the code was only for adding a non-visible note with a specific note name. This is because we use "actioned" notes as one of the mechanisms for eligibility on activating WooCommerce Payments promotions, so users having marketing disabled will still be able to enjoy the discounts. To be clear, there would be no promotional message added anywhere. Let me know if you have any further questions on this, have a great day ahead! |
This is literally a promotional message |
Actually, it was an individual page containing the promotional message under its own menu, and users would have to intentionally navigate to the page in order to view it. When a user clicks something like "Get started" button in that page, it would trigger the hidden promo note to enable the discount. |
5823022-zen |
@woocommerce/helix Does this fall under y'all's radar? If so, could we please get a priority assigned? If not, could y'all please point me to the appropriate team? Additionally, could a gist like this be used as an additional workaround? |
I have the same issues and just posted in in the Woocommerce support forum. They recommended to follow this thread. Well, ok... I tried both workarounds with no luck. Having said this, promotions like for Woocommerce payments should never EVER be prominent in the dashboard. There should be guidelines for free plugins. |
I've just found the additional GitHub thread that provides the solution. You can, of course, run the query directly in the database:
|
@csmcneill Not in particular, though if WCPay has any non-dismissable notices like this then we'd be happy to take a look. I'm not 100% familiar with this but it looks like a core issue to me, see @beaulebens comment for latest info. @psealock (from core team) may know more as he's labelled this |
Looks like it should have had the |
6213039-zen reported this as well. Their plugins are all updated but still see this. |
@woocommerce/helix could you please double-check if it's still relevant? AFAIK the issue with dismissing inbox notifications was fixed in WooCommerce 7.8 and another fix in 8.0 when localization is used (changelog). |
Thanks for following this up @vbelolapotkov 😁 As far as I understand this specific notification is no longer current – I can't find any deposits schedule content in the notifications data feed from WCCOM. Based on the discussion above, I don't know of any current issues with the notification system or dismissability of notices, so perhaps this can be closed. I'd defer to @psealock or someone from core team, who maintain the the notifications system. @psealock or @laurendavissmith which is the best team to confirm and close this? |
Prerequisites
Describe the bug
We started seeing this banner on each and every shop we developed:
This comes from the API hosted on https://woocommerce.com/wp-json/wccom/inbox-notifications/1.0/notifications.json and it's not dismissible.
This message is (IMHO) disguised as a "settings notification" but is no more than a marketing banner.
Unaware shop owners might just sign up for WooCommerce Payments, even if they already have those payments in place without going through Automattic, as they will think they're just setting up the deposit interval for the payment they already have.
The fact that it's not dismissible is very nasty.
This raises an even more important question, as all shops are susceptible to getting any message WooCommerce feels like throwing at their backend, which Automattic is rightful to do on its free product, but not as intrusive as this. Also, I found code that suggests that even if the developer disabled marketing suggestions (as I do), the notification is created anyway:
In addition to that, disabling marketing suggestions via the "woocommerce_allow_marketplace_suggestions" filter is not 100% effective because there's now another filter "woocommerce_show_marketplace_suggestions" in some places. Both are used in different places of the code.
Expected behavior
Not getting intrusive, non-dismissable, marketing banners disguised as "settings warnings".
Actual behavior
Not able to dismiss the marketing banner.
Steps to reproduce
Having WooCommerce installed.
WordPress Environment
Not relevant
Isolating the problem
The text was updated successfully, but these errors were encountered: