Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Add aria-label to wc_help_tip #35860

Closed
nathanss opened this issue Dec 6, 2022 · 3 comments · Fixed by #37808
Closed

[Enhancement]: Add aria-label to wc_help_tip #35860

nathanss opened this issue Dec 6, 2022 · 3 comments · Fixed by #37808
Assignees
@Sidsector9
Labels
Contributor Day - H1 2023 focus: accessibility The issue/PR is related to accessibility. plugin: woocommerce Issues related to the WooCommerce Core plugin. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@nathanss
Copy link
Contributor

nathanss commented Dec 6, 2022

Describe the solution you'd like

Currently, all tooltips generated with wc_help_tip are not visible by screen readers.

We could make them visible to screen readers by setting tabIndex to 0 and the aria-label attribute to the same value as the tooltip text.

Describe alternatives you've considered

No response

Additional context

No response
@nathanss nathanss added type: enhancement The issue is a request for an enhancement. focus: accessibility The issue/PR is related to accessibility. status: awaiting triage This is a newly created issue waiting for triage. labels Dec 6, 2022
@roykho roykho added needs: developer feedback Issues that need feedback from one of the WooCommerce Core developers. plugin: woocommerce Issues related to the WooCommerce Core plugin. and removed status: awaiting triage This is a newly created issue waiting for triage. labels Dec 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

Hi @nathanss,

Thank you for opening the issue! It requires further feedback from the WooCommerce Core team.

We are adding the needs developer feedback label to this issue so that the Core team could take a look.

Please note it may take a few days for them to get to this issue. Thank you for your patience.

@barryhughes
Copy link
Member

Thanks, that makes a lot of sense 👍

Adding to our backlog (and if anyone is interested in submitting a PR, we'd be receptive to that).

@barryhughes barryhughes added type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. and removed needs: developer feedback Issues that need feedback from one of the WooCommerce Core developers. labels Dec 9, 2022
@laurendavissmith laurendavissmith modified the milestone: Contributor Day - a11y / i18n Apr 6, 2023
@Sidsector9
Copy link
Member

Hello @chihsuan I'd like to pick this up.

@Sidsector9 Sidsector9 mentioned this issue Apr 19, 2023
Merged
coreymckrill added a commit that referenced this issue Apr 19, 2023
@coreymckrill
fix/35860: Adds missing aria-label and tabindex HTML attributes to th…
c772d8a 
…e Help tip element. (#37808)

Fixes #35860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sidsector9 Sidsector9

Labels
Contributor Day - H1 2023 focus: accessibility The issue/PR is related to accessibility. plugin: woocommerce Issues related to the WooCommerce Core plugin. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
Contributor Day - a11y / i18n
Status: In Review
Milestone
No milestone
5 participants
@laurendavissmith @roykho @barryhughes @nathanss @Sidsector9