Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Fix the create button at the bottom of the dropdown list #35969

Closed
5 tasks
jarekmorawski opened this issue Dec 14, 2022 · 5 comments
Closed
5 tasks
Assignees
Labels
focus: new product ux revamped product management experience focus: product management Related to product creation and editing. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. status: blocked The issue is blocked from progressing, waiting for another piece of work to be done.

Comments

@jarekmorawski
Copy link

jarekmorawski commented Dec 14, 2022

Related to #35851 -- some work on #35851 deals with the AC in this issue

We noticed in user testing that some people couldn't figure out how to add a new item in the dropdown component. In addition to the existing logic that allows users to type the name and select an option from the list to create a new item, we want to add a fixed button that will be visible at all times.

fixedcreateitem.mov

Acceptance criteria

  • There's a new item fixed at the bottom of the list. It is visible to users as they scroll up and down the list.
  • Users can quickly navigate to it using the Tab key.
  • The button is Gutenberg-Blue (it's now Gutenberg-900) and says + Create new.
  • Clicking the button or pressing Enter opens the item creation modal.
  • When users start typing, the button's label changes to + Create "[phrase]" just like it does now.
@jarekmorawski jarekmorawski added focus: product management Related to product creation and editing. focus: new product ux revamped product management experience focus: product management components labels Dec 14, 2022
@jarekmorawski jarekmorawski changed the title [Enhancement] Fix the co [Enhancement] Fix the create button at the bottom of the dropdown list Dec 14, 2022
@pmcpinto pmcpinto added the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Dec 20, 2022
@mdperez86
Copy link
Contributor

Newly created item is placed at the bottom of the list.

@jarekmorawski this is not possible if we apply some sorting criteria to the list like: by name, or anything different to the id

@mattsherman mattsherman added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Jan 24, 2023
@octaedro
Copy link
Contributor

octaedro commented Mar 1, 2023

Hey @jarekmorawski,
Considering this comment is it ok if we remove that AC (Newly created item is placed at the bottom of the list)?

@jarekmorawski
Copy link
Author

Removed. ✔️

@nathanss nathanss self-assigned this Mar 1, 2023
@nathanss
Copy link
Contributor

nathanss commented Mar 2, 2023

I created the issue #37043, I think we should migrate to the new TreeControl component before implementing this to avoid rework.

@nathanss
Copy link
Contributor

Closed by #37479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: new product ux revamped product management experience focus: product management Related to product creation and editing. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. status: blocked The issue is blocked from progressing, waiting for another piece of work to be done.
Projects
None yet
7 participants