Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E: Use waitUntil instead of waitForLoadState in page.goto() #36698

Closed
rodelgc opened this issue Jan 31, 2023 · 4 comments · Fixed by #37831
Closed

E2E: Use waitUntil instead of waitForLoadState in page.goto() #36698

rodelgc opened this issue Jan 31, 2023 · 4 comments · Fixed by #37831
Assignees
@ravinderk
Labels
Contributor Day - H1 2023 focus: smoke tests These Issues/PRs relate to smoke testing. type: enhancement The issue is a request for an enhancement. type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@rodelgc
Copy link
Contributor

rodelgc commented Jan 31, 2023 •
edited

In our E2E tests, there are page.goto()'s that use waitForLoadState as an option.

QsaNwwGWlg

We must change them to waitUntil because that's the valid option according to the Playwright docs.
@rodelgc rodelgc added type: enhancement The issue is a request for an enhancement. status: awaiting triage This is a newly created issue waiting for triage. type: task The issue is an internally driven task (e.g. from another A8c team). focus: smoke tests These Issues/PRs relate to smoke testing. and removed status: awaiting triage This is a newly created issue waiting for triage. labels Jan 31, 2023
@rodelgc rodelgc mentioned this issue Jan 31, 2023
Merged
6 tasks
@laurendavissmith laurendavissmith modified the milestone: Contributor Day - Infra Apr 6, 2023
@ravinderk
Copy link
Contributor

@rodelgc 🤚 I would like to work on this

@rodelgc
Copy link
Contributor Author

rodelgc commented Apr 18, 2023

@rodelgc 🤚 I would like to work on this

That's great @ravinderk 🙌
Sure! I'll update the issue description to clarify that you'll be contributing to it. And let us know here if you got any questions 🥂

@rodelgc rodelgc assigned ravinderk and unassigned ravinderk Apr 18, 2023
@rodelgc rodelgc mentioned this issue Apr 19, 2023
Closed
2 tasks
@ravinderk ravinderk mentioned this issue Apr 19, 2023
Merged
@nigeljamesstevenson
Copy link
Contributor

Hi folks, not sure this issue should be closed- I have added a comment to the resolving PR - If I have missed something then let me know 😊

@nigeljamesstevenson
Copy link
Contributor

Closed based on @lanej0 comment in related PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravinderk ravinderk

Labels
Contributor Day - H1 2023 focus: smoke tests These Issues/PRs relate to smoke testing. type: enhancement The issue is a request for an enhancement. type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
Contributor Day - Infra
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Use waitUntil instead of waitForLoadState in page.goto() ravinderk/woocommerce
4 participants
@laurendavissmith @ravinderk @rodelgc @nigeljamesstevenson