New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Use waitUntil
instead of waitForLoadState
in page.goto()
#37831
Conversation
use waitUntil instead of waitForLoadState.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #37831 +/- ##
==========================================
- Coverage 51.5% 51.5% -0.0%
- Complexity 17261 17281 +20
==========================================
Files 429 430 +1
Lines 79957 80030 +73
==========================================
+ Hits 41215 41217 +2
- Misses 38742 38813 +71 |
plugins/woocommerce/tests/e2e-pw/tests/merchant/order-refund.spec.js
Outdated
Show resolved
Hide resolved
plugins/woocommerce/tests/e2e-pw/tests/merchant/order-refund.spec.js
Outdated
Show resolved
Hide resolved
plugins/woocommerce/tests/e2e-pw/tests/merchant/order-refund.spec.js
Outdated
Show resolved
Hide resolved
plugins/woocommerce/tests/e2e-pw/tests/merchant/page-loads.spec.js
Outdated
Show resolved
Hide resolved
@tammullen I reverted changes related to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for this contribution!
Remove waits, failing on CI
Hi folks, a bit late to the party on this one. I might be missing something here but it appears that the code Is this expected @lanej0 @tammullen? |
That was me @nigeljamesstevenson -- the tests started failing with the update. I don't think we need an explicit wait in those places anyhow, so I tried removing and ran the tests a bunch of times without issue. |
Submission Review Guidelines:
Changes proposed in this Pull Request:
I found that in few playwright tests, we are using
waitForLoadState
. This is not correct argument togoto
andclick
. I replace it withwaitUntil
.Closes #36698 .
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changed playwright E2E tests should pass.