Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task List completion message is wrong when no tasks completed #37554

Closed
5 tasks done
adrianduffell opened this issue Apr 3, 2023 · 0 comments · Fixed by #38092
Closed
5 tasks done

Task List completion message is wrong when no tasks completed #37554

adrianduffell opened this issue Apr 3, 2023 · 0 comments · Fixed by #38092
Assignees
Labels
focus: setup checklist Issue related to onboarding task list. type: bug The issue is a confirmed bug.

Comments

@adrianduffell
Copy link
Contributor

Prerequisites

  • I have carried out troubleshooting steps and I believe I have found a bug.
  • I have searched for similar bugs in both open and closed issues and cannot find a duplicate.

Describe the bug

When no tasks are completed, the default message is shown instead of Let's get you started.

This is because the completed count isn't checked for >=0 in the conditional.

if ( completedCount > 0 && completedCount < 4 ) {
return __( "Let's get you started", 'woocommerce' ) + ' 🚀';
}


Screen Shot 2023-04-03 at 2 23 40 pm

Expected behavior

When no tasks are completed, the message should say Let's get you started.

Actual behavior

When no tasks are completed, the message says You are on the right track.

Steps to reproduce

  1. Start a fresh site
  2. Skip the onboarding wizard so no tasks complete
  3. View the homepage and see the message above the task list

WordPress Environment

n/a

Isolating the problem

  • I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.
  • This bug happens with a default WordPress theme active, or Storefront.
  • I can reproduce this bug consistently using the steps above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: setup checklist Issue related to onboarding task list. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants