Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tasklist completion message when no tasks are completed #38092

Merged
merged 2 commits into from May 5, 2023

Conversation

chihsuan
Copy link
Member

@chihsuan chihsuan commented May 3, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #37554.

When one of the tasks is visited and no tasks are completed, the message should say Let's get you started.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Start a fresh site
  2. Skip the onboarding wizard so no tasks complete
  3. Go to WooCommerce > Home
  4. See the message above the task list
  5. The message should display "Welcome to your store"
  6. Click on Add products task
  7. Go back to WooCommerce > Home
  8. The message should display "Let's get you started 🚀"

@chihsuan chihsuan self-assigned this May 3, 2023
@chihsuan chihsuan marked this pull request as ready for review May 3, 2023 09:24
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 3, 2023
@chihsuan chihsuan requested review from a team, ilyasfoo and rjchow May 3, 2023 09:25
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Hi @ilyasfoo, @rjchow, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Test Results Summary

Commit SHA: b9ea74b

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26700202691m 15s
E2E Tests1870010019714m 41s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests well! Thanks for adding tests! 🚢

@chihsuan
Copy link
Member Author

chihsuan commented May 5, 2023

Going to merge this with one approval only since it's a small change and I've also added tests for it.

@chihsuan chihsuan merged commit 208ac81 into trunk May 5, 2023
21 checks passed
@chihsuan chihsuan deleted the fix/tasklist-completion-message branch May 5, 2023 09:48
@github-actions github-actions bot added this to the 7.8.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task List completion message is wrong when no tasks completed
2 participants