Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Block Editor: Create product attributes block #37728

Closed
3 tasks
louwie17 opened this issue Apr 14, 2023 · 2 comments · Fixed by #38051
Closed
3 tasks

Product Block Editor: Create product attributes block #37728

louwie17 opened this issue Apr 14, 2023 · 2 comments · Fixed by #38051
Assignees
Labels
focus: product management Related to product creation and editing. plugin: woocommerce Issues related to the WooCommerce Core plugin.

Comments

@louwie17
Copy link
Contributor

louwie17 commented Apr 14, 2023

Description

This issue will cover the creation of the product attributes block as we had designed in the original implementation.
With a few small additional changes (these changes can be done within the component as we will be replacing the current implementation with the block editor soon):

  • The add attribute modal contains a description below the title
  • The By default, new attributes are filterable and visible on the product page. You can change these settings for each attribute separately later. notice shown at the top has been moved down.

Items shown in the designs that aren't part of this issue

  • The entire right column in the add and edit modals (the preview)

Image

Image

Designs

AkVNGImLgSqCObTQ3idVn7-fi-1005_169648

Acceptance criteria

  • Include a new Attributes section with the correct icon and description that contains the attributes field.
  • Add attribute button should be present rendering a Modal to allow users to add attributes ( same as old design )
  • Once attributes are added they can be edited, re-ordered, removed (same as the old design).
@github-actions github-actions bot added the status: awaiting triage This is a newly created issue waiting for triage. label Apr 14, 2023
@louwie17 louwie17 added plugin: woocommerce Issues related to the WooCommerce Core plugin. focus: product management Related to product creation and editing. and removed status: awaiting triage This is a newly created issue waiting for triage. labels Apr 14, 2023
@joelclimbsthings joelclimbsthings self-assigned this Apr 25, 2023
@joelclimbsthings
Copy link
Contributor

joelclimbsthings commented Apr 28, 2023

So I'm currently uncertain how to handle the lack of dragging functionality here due to it being suppressed within blocks (same as images). For the Images block we're removing dragging functionality temporarily, but in this case that is the only method we have for reordering attributes.

Any thoughts on the above @louwie17 @mdperez86 @joshuatf @jarekmorawski ?

@louwie17
Copy link
Contributor Author

louwie17 commented May 1, 2023

So I'm currently uncertain how to handle the lack of dragging functionality here due to it being suppressed within blocks (same as images). For the Images block we're removing dragging functionality temporarily, but in this case that is the only method we have for reordering attributes.

@joelclimbsthings as part of this issue, I would create the attributes block with the drag and drop removed/disabled if that is easily done? We can do a follow up issue to support drag & drop.
In the mean time @jarekmorawski would it be worth adding arrows for changing the order? Adding drag & drop support would have to be pushed to the following cycle (most likely), as it will require us turning the attributes into individual blocks within the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: product management Related to product creation and editing. plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants