New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding attributes block to product block editor. #38051
Conversation
8bfa2f4
to
03605ef
Compare
Hi @joshuatf, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 47752bc
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Left one question about an unused component, but pre-approving.
Noting that the drag and drop functionality does not work here, but I think we should get this merged and continue to iterate on this experience once we've made some decisions around how we want to handle that.
@@ -35,7 +35,7 @@ | |||
"@woocommerce/components": "workspace:*", | |||
"@woocommerce/currency": "workspace:*", | |||
"@woocommerce/customer-effort-score": "workspace:*", | |||
"@woocommerce/data": "workspace:^4.1.0", | |||
"@woocommerce/data": "workspace:*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
@@ -19,7 +18,7 @@ type AttributeEmptyStateProps = { | |||
}; | |||
|
|||
export const AttributeEmptyState: React.FC< AttributeEmptyStateProps > = ( { | |||
image = AttributeEmptyStateLogo, | |||
image, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for removing the default image here? Looks like we're also no longer using this component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope! Not a good one. Just removed that component in 9048f92.
@@ -19,7 +18,7 @@ type AttributeEmptyStateProps = { | |||
}; | |||
|
|||
export const AttributeEmptyState: React.FC< AttributeEmptyStateProps > = ( { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we need to keep this component if it's no longer in use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, just removed in 9048f92 👍🏻
53c7eff
to
9048f92
Compare
Thanks @joshuatf , just removed that component as suggested. 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing that extra component. LGTM!
Submission Review Guidelines:
Changes proposed in this Pull Request:
This moves all attributes components (there are many) to the product-editor package and adds a block container. Certain logic and styling changes are made to match the updated design.
Note that some of the changes also impact the old editor using the same component(s), in a slightly less than ideal but non-breaking way. This is considered fine since it will be deprecated very soon.
Also note that dragging does not work for the same reason as the images, and I'm a bit uncertain on how to handle thus far.
Closes #37728 .
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
product-block-editor
feature flag with the WCA Test Helper plugin.AkVNGImLgSqCObTQ3idVn7-fi-1761-446426&t=kYXzUnc4UoMZ91dd-4