Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assertion in afterAll hook in create-post.spec #38195

Open
rodelgc opened this issue May 10, 2023 · 0 comments
Open

Remove assertion in afterAll hook in create-post.spec #38195

rodelgc opened this issue May 10, 2023 · 0 comments
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Vortex WooCommerce monorepo tools and test suite. type: enhancement The issue is a request for an enhancement.

Comments

@rodelgc
Copy link
Contributor

rodelgc commented May 10, 2023 •
edited

We can probably remove this assertion because:

  • it looks like we're verifying the response of WP's "delete post" endpoint, which we shouldn't because we're not testing the WP endpoint anyway. We'll just have to trust that it would work, since it's an endpoint that we don't have control of.
  • before and after hooks probably don't need any kind of assertions
@github-actions github-actions bot added the status: awaiting triage This is a newly created issue waiting for triage. label May 10, 2023
@rodelgc rodelgc added plugin: woocommerce Issues related to the WooCommerce Core plugin. focus: e2e tests Issues related to e2e tests and removed status: awaiting triage This is a newly created issue waiting for triage. labels May 10, 2023
@rodelgc rodelgc mentioned this issue May 10, 2023
Merged
@juliaamosova juliaamosova added team: Vortex WooCommerce monorepo tools and test suite. and removed team: Solaris labels Mar 29, 2024
@tammullen tammullen added priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement. labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Vortex WooCommerce monorepo tools and test suite. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rrennick @rodelgc @juliaamosova @tammullen