New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playwright 1.33 and UI mode #38100
Playwright 1.33 and UI mode #38100
Conversation
Test Results SummaryCommit SHA: 31af82f
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## trunk #38100 +/- ##
==========================================
- Coverage 51.2% 51.2% -0.0%
Complexity 17421 17421
==========================================
Files 440 440
Lines 80640 80640
==========================================
- Hits 41312 41310 -2
- Misses 39328 39330 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally the UI mode! I'm sure it will be very beneficial for folks contributing to E2E tests. Maybe we'd need to advocate this feature and let people know about it.
Thank you very much for bringing it to the project @lanej0!
Looks good to me. Tested using the I also tested it with I'm ok with approving the PR once p1683611925286349/1683578158.765189-slack-C01BWDDTGKX was resolved. |
Seems like the "Changelogger use" check didn't complete. But looking at https://github.com/woocommerce/woocommerce/actions/runs/4896612868, it seems that it successfully ran. I re-ran the changelogger check and it completed fine, but it still shows up as waiting for completion in the checks list. |
Looks good to me - great to get this one over the line - UI mode seems very useful indeed 😊 |
# Conflicts: # pnpm-lock.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expect( response.ok() ).toBeTruthy(); | ||
// expect( response.ok() ).toBeTruthy(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call commenting this out. I think we should remove the assertion, and clean up the response
variable above it. I created a separate task for it in #38195.
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR updates Playwright to version 1.33 and introduces the UI mode command.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
pnpm env:start
pnpm test:e2e-pw
(you may have to runpnpx playwright install
first -- you'll be prompted)pnpm test:e2e-pw-ui