Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Profiler -- Plugin selection is not persisted #38903

Closed
moon0326 opened this issue Jun 22, 2023 · 0 comments · Fixed by #38922
Closed

Core Profiler -- Plugin selection is not persisted #38903

moon0326 opened this issue Jun 22, 2023 · 0 comments · Fixed by #38922
Labels
focus: onboarding wizard Issue related to onboarding wizard. type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@moon0326
Copy link
Contributor

moon0326 commented Jun 22, 2023 •
edited

Reported in pdibGW-26P-p2#comment-1557

Description

When a user manually selects plugins A and B
Then clicks Continue button
And the plugin installation fails for some reason
Then the user is redirected to the plugin page with error messages
But the plugin selection is reset to the initial stage

The plugin selection should be persisted. In this case, only plugins A and B should be selected.

Steps to reproduce

  1. Start with a fresh site
  2. Start the core profiler and proceed to the plugins page as usual
  3. Select only mailpoet plugin
  4. Open terminal and go to your local WordPress plugins directory (wp-content/plugins)
  5. Run mkdir mailpoet && touch mailpoet/test.txt. This will cause an error for the plugin installation.
  6. Click Continue to start the plugin installation.
  7. You should be redirected to the plugins page with error messages.
  8. Confirm the plugin selection is back to the initial state.
@github-actions github-actions bot added the status: awaiting triage This is a newly created issue waiting for triage. label Jun 22, 2023
@moon0326 moon0326 changed the title Enhancement - Persist plugin selection Core Profiler -- Plugin selection is not persisted Jun 22, 2023
@ilyasfoo ilyasfoo added type: task The issue is an internally driven task (e.g. from another A8c team). focus: onboarding wizard Issue related to onboarding wizard. and removed status: awaiting triage This is a newly created issue waiting for triage. labels Jun 23, 2023
@moon0326 moon0326 mentioned this issue Jun 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
focus: onboarding wizard Issue related to onboarding wizard. type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore plugins selection when there is an error woocommerce/woocommerce
2 participants
@ilyasfoo @moon0326