New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore plugins selection when there is an error #38922
Restore plugins selection when there is an error #38922
Conversation
Hi @chihsuan, @adrianduffell, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
2 similar comments
Hi @chihsuan, @adrianduffell, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Hi @chihsuan, @adrianduffell, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 4148727
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well! However, I've tried with selecting other plugins along which were successfully installed, it seems it also attempts to retry the other plugins (I assume it might be the other plugins stays selected despite no checkbox shown).
Though not a big deal since the extra API request is pretty fast. Pre-approving!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested well. 🚢
Thank you for cathing it. I'll address it in a separate PR 👍 |
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #38903
This PR restores user's plugin selection on there is an installation error.
How to test the changes in this Pull Request:
rm -rf mailpoet && mkdir mailpoet && touch mailpoet/test.txt
. This will cause an installation error.Mailpeot
only.Continue
Mailpoet
is selected.