Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore plugins selection when there is an error #38922

Merged

Conversation

moon0326
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #38903

This PR restores user's plugin selection on there is an installation error.

How to test the changes in this Pull Request:

  1. Start with a new JN site and start the core profiler.
  2. Proceed to the plugins page.
  3. Confirm all the plugins are selected by default.
  4. Open your terminal and cd to your WP plugins directory (wp-content/plugins)
  5. Run rm -rf mailpoet && mkdir mailpoet && touch mailpoet/test.txt. This will cause an installation error.
  6. Select Mailpeot only.
  7. Click Continue
  8. You should be redirected to the plugins page with an error.
  9. Confirm only Mailpoet is selected.

@moon0326 moon0326 requested review from a team, chihsuan and adrianduffell June 23, 2023 19:10
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 23, 2023
@github-actions
Copy link
Contributor

Hi @chihsuan, @adrianduffell, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

2 similar comments
@github-actions
Copy link
Contributor

Hi @chihsuan, @adrianduffell, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

Hi @chihsuan, @adrianduffell, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 4148727

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 49s
E2E Tests1900018020814m 5s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well! However, I've tried with selecting other plugins along which were successfully installed, it seems it also attempts to retry the other plugins (I assume it might be the other plugins stays selected despite no checkbox shown).

Though not a big deal since the extra API request is pretty fast. Pre-approving!

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well. 🚢

@moon0326
Copy link
Contributor Author

Tested well! However, I've tried with selecting other plugins along which were successfully installed, it seems it also attempts to retry the other plugins (I assume it might be the other plugins stays selected despite no checkbox shown).

Though not a big deal since the extra API request is pretty fast. Pre-approving!

Thank you for cathing it. I'll address it in a separate PR 👍

@moon0326 moon0326 merged commit ac1b5f0 into trunk Jun 27, 2023
21 checks passed
@moon0326 moon0326 deleted the update/38903-core-profiler-plugins-selection-is-not-persisted branch June 27, 2023 00:31
@github-actions github-actions bot added this to the 8.0.0 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core Profiler -- Plugin selection is not persisted
3 participants