Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Unscoped NPM Packages #40953

Closed
ObliviousHarmony opened this issue Oct 23, 2023 · 0 comments
Closed

Rename Unscoped NPM Packages #40953

ObliviousHarmony opened this issue Oct 23, 2023 · 0 comments
Assignees
@ObliviousHarmony
Labels
focus: monorepo infrastructure Issues and PRs related to monorepo tooling. team: Kirigami & Origami type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@ObliviousHarmony
Copy link
Contributor

ObliviousHarmony commented Oct 23, 2023 •
edited

Currently, there are projects within our monorepo that have no scope. We need to add a scope to avoid the possibility of accidentally grabbing an external dependency. We also have some invalid package names that we need to resolve.

Acceptance Criteria

  • Plugins have @woocommerce/plugin-{slug} name in package.json.
  • plugins/woocommerce-admin should have @woocommerce/admin-library as the name.
  • woocommerce/client/legacy should have @woocommerce/shortcode-assets as the name.
  • Documentation update for clarity
@ObliviousHarmony ObliviousHarmony added the focus: monorepo infrastructure Issues and PRs related to monorepo tooling. label Oct 23, 2023
@ObliviousHarmony ObliviousHarmony mentioned this issue Oct 23, 2023
Closed
@ObliviousHarmony ObliviousHarmony added the type: task The issue is an internally driven task (e.g. from another A8c team). label Oct 24, 2023
@ObliviousHarmony ObliviousHarmony self-assigned this Nov 16, 2023
@ObliviousHarmony ObliviousHarmony mentioned this issue Nov 17, 2023
Merged
11 tasks
@ObliviousHarmony ObliviousHarmony mentioned this issue Dec 9, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ObliviousHarmony ObliviousHarmony

Labels
focus: monorepo infrastructure Issues and PRs related to monorepo tooling. team: Kirigami & Origami type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rrennick @ObliviousHarmony