Refactor Task Infrastructure #41988
Merged
Refactor Task Infrastructure #41988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NPM package names _must_ either be single-word or have a scope. The current structure is unsupported and has been changed. The new package name is `@woocommerce/admin-library`.
NPM requires names to be single-word or have a scope. The current name is not valid. The package has been renamed `@woocommerce/shortcode-assets` to better match its purpose.
In order to prevent supply-chain attacks we have renamed the package. The new name is `@woocommerce/plugin-woocommerce`.
As part of the prevention of supply chain attacks we are renaming the package `@woocommerce/plugin-woocommerce-beta-tester`.
As part of preventing supply chain attacks, the package was renamed `@woocommerce/plugin-woo-ai`.
As part of the prevention of supply chain attacks the package has been renamed to `@woocommerce/plugin-woocommerce-docs`.
We're adding this to _every_ package since they have their own configuration and scripts to run. This also keeps them isolated so that they can operate independently.
We can use a PNPM hook to make sure that the dependencies are accounted for in the fingerprint. This script scans through all of the packages with Wireit and adds the outputs for linked dependencies.
We're going to use an automatic script to make these changes.
We will never run all tests concurrently so this is better.
There's quite a bit of work needed in this file but I'll come back to that later when I can review it all in more detail.
github-actions
bot
added
the
plugin: woocommerce beta tester
Test Results SummaryCommit SHA: 05d398c
Please address the following issues prior to merging this pull request: |
samueljseay
reviewed
Dec 10, 2023
|
Everything is working well for me. I've tested out some blocks via the built-in dev env ( I'll continue to test locally but everything is working as expected so far! |
ObliviousHarmony
force-pushed
the
refactor/task-infrastructure
branch
from
d8724a9
to
05d398c
Compare
github-actions
bot
added
the
needs: analysis
alopezari
added
status: analysis complete
10 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
This pull request makes a number of changes to our task orchestration infrastructure in order to introduce consistency and significantly improve cache performance. Generally speaking, from the user-perspective, there should be very little changed by this pull request.
Note: I chose to batch the changes in this PR so that it will have a minimal impact on developer experience by being merged at the same time.
Closes #40954, #40952, #40953.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
pnpm --filter='@woocommerce/plugin-woocommerce' buildpnpm --filter='@woocommerce/plugin-woocommerce' lintpnpm --filter='@woocommerce/plugin-woocommerce' buildChangelog entry
Significance
Type
Message
Comment