Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Products (Beta) block. Same size images #42415

Closed
paaljoachim opened this issue Apr 10, 2023 · 8 comments
Closed

Products (Beta) block. Same size images #42415

paaljoachim opened this issue Apr 10, 2023 · 8 comments
Labels
block-type: product-query Issues related to/affecting all product-query variations. team: Kirigami & Origami type: enhancement The issue is a request for an enhancement.

Comments

@paaljoachim
Copy link

Using the Products (Beta) block for a site I see this:
Screenshot 2023-04-10 at 14 00 16

Notice how uneven this is. We might need to bring this into the Query Loop block in Gutenberg and then it would show up in the Products block in WooCommerce.

@paaljoachim paaljoachim added the type: enhancement The issue is a request for an enhancement. label Apr 10, 2023
@albarin albarin added the block-type: product-query Issues related to/affecting all product-query variations. label Apr 11, 2023
@albarin
Copy link
Contributor

albarin commented Apr 12, 2023

@paaljoachim Thanks a lot for reporting this! We have added the issue to our backlog. We'll let you know of any updates.

@paaljoachim
Copy link
Author

paaljoachim commented Apr 12, 2023

Hey @albarin

This might also be a Query Loop block issue.
I just checked the Query Loop block and noticed this:
Screenshot 2023-04-12 at 13 14 16

It uses the Post Featured Image block and that adds various options which make it possible to have various images the same size. For instance I used cover so that an image fills out the space.

While the Product Image block uses this:
Screenshot 2023-04-12 at 13 18 38

I believe it just needs to add the various Query Loop block Post Featured Image settings.

@imanish003
Copy link
Contributor

Hi @paaljoachim, thank you for taking the time to submit an issue. Your contribution is greatly appreciated! 🙌🏻

It does make sense to add width, height, and scale controls for the Product Image. That way, we can ensure consistent width and height for product images. Currently, we are using our own block, the Product Image, instead of the Post Featured Image. As a result, they don't share the same controls. One reason for using our own Product Image block is the need to display the Sale badge on the image.

@imanish003 imanish003 added the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Apr 18, 2023
@paaljoachim
Copy link
Author

Hi @imanish003

Perhaps it would be better to use a custom Post Featured Image block to where one can also display the Sale badge. Adding a panel named Sale Badge which include the needed controls.

@imanish003
Copy link
Contributor

Hi @paaljoachim, 👋

That makes sense. 💡 We've had internal discussions about replacing the Product Image with a more versatile block, such as the Cover block or Post Featured Image block, and incorporating the On-Sale badge as an inner block. Our goal is to enhance customization options for the Product Image and Sale badge.

Your input is greatly appreciated. 🙏 Upon reviewing the issues, I found #42478, which appears to address the same topic. Consequently, I've resumed the discussion there. 💬

@kmanijak
Copy link
Contributor

kmanijak commented May 5, 2023

Providing additional information from another issue (woocommerce/woocommerce-blocks#8338) about the same topic:

For reference, Gutenberg has a similar issue for the Image block: WordPress/gutenberg#38990.

Also, aspect ratio has been added to the Post Featured Image block (WordPress/gutenberg#47854) with design follow-ups here (WordPress/gutenberg#47963). 🚀

@paaljoachim
Copy link
Author

paaljoachim commented May 5, 2023

Btw I am going to add the comment I made into the other issue here:
#42478

We should probably keep discussions in the 8355 issue.

Bottom line is that a block is needed that can add an image and inner block so the user can add a sales badge. Currently that is only the Cover block which can handle. Group block can not handle adding an image directly.

@ObliviousHarmony ObliviousHarmony transferred this issue from woocommerce/woocommerce-blocks Dec 11, 2023
@tjcafferkey tjcafferkey removed the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Dec 18, 2023
@paaljoachim
Copy link
Author

I will close this issue. Because of this followup.
#44387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block-type: product-query Issues related to/affecting all product-query variations. team: Kirigami & Origami type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

6 participants