Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Collection: try replacing Product Image with Cover block #44387

Open
kmanijak opened this issue Feb 6, 2024 · 4 comments
Open

Product Collection: try replacing Product Image with Cover block #44387

kmanijak opened this issue Feb 6, 2024 · 4 comments
Labels
block: product collection Issues related to the Product Collection block team: Kirigami & Origami type: enhancement The issue is a request for an enhancement.

Comments

@kmanijak
Copy link
Contributor

kmanijak commented Feb 6, 2024

Background
In the issue #44146 (comment), there's a suggestion to replace Product Image with Cover block so we enable all of the Cover block features. Also, it would open new capabilities in terms of patterns creation.

@nerrad proved in a quick check there's no obvious problem with that:
image

Goal:

  • Double check there are no negative side effects of using Cover instead of Product Image
  • Make sure Cover block covers Product Image capabilities
  • If no problems are detected:
    • replace Product Image with Cover (+ On Sale Badge) block in patterns that include Product Collection
    • use Cover (+ On Sale Badge) as a default block in Product Collection
@paaljoachim
Copy link

It is awesome to see the quick response and followup!

@paaljoachim
Copy link

paaljoachim commented Feb 6, 2024

The Cover block now has Dimensions: Add Aspect Ratio block support making it possible to create product images that are the same size.

I am also suggesting creating a new Sales Badge block which by default is added as a inner block to the Cover block as I believe it will add a greater flexibility compared to the current implementation. #44392

@nerrad
Copy link
Contributor

nerrad commented Feb 6, 2024

Thanks @paaljoachim, just noting we've created the issue to track this but there's still some diligence we're working through before committing to any changes.

@Marc-pi
Copy link

Marc-pi commented Mar 27, 2024

yep, the aspect ratio is needed in several areas, included the Related products template / loop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block: product collection Issues related to the Product Collection block team: Kirigami & Origami type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

4 participants