Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edits to Product Archive template are not visible in the Product Category and Product Tag pages #42656

Closed
Aljullu opened this issue Jan 5, 2022 · 5 comments
Closed

Edits to Product Archive template are not visible in the Product Category and Product Tag pages #42656

Aljullu opened this issue Jan 5, 2022 · 5 comments
Labels
focus: FSE Issues related to Full Site Editing team: Kirigami & Origami type: bug The issue is a confirmed bug.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Jan 5, 2022

I might be understanding this wrong, but I think that if Product Category and Product Tag templates haven't been customized and don't have a custom template set by the theme, but the Product Archive has been customized by the user, the Product Archive template should take priority.

To reproduce

  1. With WP 5.9 and a Twenty Twenty Two, go to Appearance > Editor > Templates.
  2. Edit the Product Archive template.
  3. Now, go to a product category or product tag page in the frontend (ie: /product-category/clothing/).
  4. Notice changes are not applied in that page.

Expected behavior

Any change in the Product Archive template should be applied to the Product Category and Product Tag pages if they hadn't been customized or the theme doesn't have a specific template for them.

Screenshots

Editor:
imatge

Frontend:
imatge

Environment

WordPress (please complete the following information):

  • Core version: tested in WP 5.9 beta 4 and RC 1
  • Gutenberg version (if installed): tested with GB 12.3.0 and disabled
  • WooCommerce version: trunk and 6.1 RC1
  • WooCommerce Blocks version: trunk and disabled
@Aljullu Aljullu added type: bug The issue is a confirmed bug. focus: FSE Issues related to Full Site Editing labels Jan 5, 2022
@tjcafferkey
Copy link
Contributor

I can see an argument for it working the way you've described in this PR and the way it currently works. It's worth noting as well that if we decide it should behave the way you've outlined above then this should also apply to themes who only have the archive-product.html file. Should they edit this file from the theme in the Site Editor it should also be applied to Category and Tag pages if they haven't already been customised.

We just need to come to a decision of the correct behaviour before moving forward with this I think.

sunyatasattva referenced this issue in woocommerce/woocommerce-blocks Jan 13, 2022
@sunyatasattva
Fallback to customized Product Archive template if no better Category…
340f08b 
… or Tag templates are present

If the user has customized the `archive-product` template and there is no better choice for the Category
or Tag, then the custom Product Archive is chosen.

The priority order is the following:

1. Custom Taxonomy Template
2. Taxonomy Template from the Theme
3. Custom Product Archive Template
4. Product Archive Template from the Theme

Fixes #5520
@sunyatasattva sunyatasattva mentioned this issue Jan 13, 2022
Closed
1 task
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Issues that have no had any activity for some time. label Mar 14, 2022
@sunyatasattva sunyatasattva removed the status: stale Issues that have no had any activity for some time. label Mar 22, 2022
sunyatasattva referenced this issue in woocommerce/woocommerce-blocks Apr 22, 2022
@sunyatasattva
Fallback to customized Product Archive template if no better Category…
8bf8de1 
… or Tag templates are present

If the user has customized the `archive-product` template and there is no better choice for the Category
or Tag, then the custom Product Archive is chosen.

The priority order is the following:

1. Custom Taxonomy Template
2. Taxonomy Template from the Theme
3. Custom Product Archive Template
4. Product Archive Template from the Theme

Fixes #5520
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Issues that have no had any activity for some time. label May 21, 2022
@Aljullu Aljullu removed the status: stale Issues that have no had any activity for some time. label May 23, 2022
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Issues that have no had any activity for some time. label Jul 23, 2022
@sunyatasattva sunyatasattva removed the status: stale Issues that have no had any activity for some time. label Jul 26, 2022
@Aljullu Aljullu mentioned this issue Aug 16, 2022
Closed
@ObliviousHarmony ObliviousHarmony transferred this issue from woocommerce/woocommerce-blocks Dec 11, 2023
@sunyatasattva sunyatasattva removed their assignment Dec 19, 2023
@Aljullu
Copy link
Contributor Author

Aljullu commented Mar 19, 2024

This was fixed in woocommerce/woocommerce-blocks#7712.

@Aljullu Aljullu closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
focus: FSE Issues related to Full Site Editing team: Kirigami & Origami type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
4 participants
@nerrad @sunyatasattva @Aljullu @tjcafferkey