This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Make Products by category/tag/attribute fallback to the Product catalog template
#7712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: |
TypeScript Errors ReportFiles with errors: 428 🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +15 B (0%) Total Size: 971 kB
ℹ️ View Unchanged
|
albarin
force-pushed
the
7648/exploration-fallback-2
branch
7 times, most recently
from
875ff18
to
ab938be
Compare
albarin
force-pushed
the
7648/exploration-fallback-2
branch
from
ab938be
to
04be103
Compare
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
albarin
changed the title
Products by category/tag/attribute fallback to the Product catalog template
albarin
added
the
focus: template
rubikuserbot
requested review from
a team and
Aljullu
and removed request for
a team
Aljullu
approved these changes
Nov 22, 2022
It was checking a single product for the customization, but it should check the /shop page
|
@Aljullu I've made some more changes, in case you want to review: There are a few tests failing right now because of an issue that is being fixed here: WordPress/gutenberg#45992, once that is merged and we update the version of the |
Aljullu
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
Thanks for investigating the failing tests, @albarin! I did a quick round of testing and everything seems to be working well, and code changes look good.
There are a few tests failing right now because of an issue that is being fixed here: WordPress/gutenberg#45992, once that is merged and we update the version of the
e2e-test-utilsthey should pass.
Do you think we should disable those test until we can update e2e-test-utils and get them pass?
4 tasks
This was referenced Dec 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make the
Products by Category,Products by Tag, andProducts by Attributetemplates fall back to theProduct Catalogone.That means that if neither the theme nor the user has customized one of those three templates, it will look like the Product Catalog one.
Fixes #7648
User Facing Testing
Pre-requisites for testing
Enabled Archivesand some products associated with it.Product by category/tag/attributefall back toProduct Catalogif not customizedhttps://store.local/wp-admin/site-editor.php?postType=wp_template.Product Catalogtemplate, add some customization and save./shopand make sure you see the customization you just did.product-category/clothing/,/product-tag/music,color/red, depending on your store configuration)./Product Catalogtemplate, meaning you see exactly the same customization you did on theProduct Catalog.Product by category/tag/attributecustomizations take priority overProduct Catalogoneshttps://store.local/wp-admin/site-editor.php?postType=wp_template.Product by Attributetemplate, add some customization and save.Product Catalogtemplate, add some customization and save.Product by Attribute./shop, to a category, and a tag page and check that you see the customization fromProduct Catalog.Product by TagandProduct by Categorytemplates.Product by category/tag/attributefall back toProduct Catalogfrom the themehttps://store.local/wp-admin/site-editor.php?postType=wp_template.archive-product.htmlto yourtemplatesfolder of your theme with some identifiable changes./shopand make sure you see the template you just added.product-category/clothing/,/product-tag/music,color/red, depending on your store configuration).Product Catalogtemplate from the theme.Product by category/tag/attributefrom theme take priority overProduct Cataloghttps://store.local/wp-admin/site-editor.php?postType=wp_template.archive-product.htmlto yourtemplatesfolder of your theme with some identifiable changes.taxonomy-product_attribute.htmlto yourtemplatesfolder of your theme with some identifiable changes.taxonomy-product_attribute.htmltemplate./shop, to a category, and a tag page and check that they are using thearchive-product.html.Product by Tag(filetaxonomy-product_tag.html) andProduct by Category(filetaxonomy-product_cat.html).Test any other combination of file templates and customized templates in the db you can think of.
In general, the priority should be:
TaxonomytemplateTaxonomytemplate from the themeProduct CatalogtemplateProduct Catalogtemplate from the themeProduct Catalogtemplate from blocksI made this table 👇 with all the possible combinations of theme and customized templates and the result template I think they should render (could be useful to make some more testing cases):
WooCommerce Visibility
Changelog