Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CYS - Core]: wp-admin screen visible for a moment after clicking "Start Designing" #45542

Closed
Tracked by #43623
gigitux opened this issue Mar 13, 2024 · 0 comments · Fixed by #45586
Closed
Tracked by #43623

[CYS - Core]: wp-admin screen visible for a moment after clicking "Start Designing" #45542

gigitux opened this issue Mar 13, 2024 · 0 comments · Fixed by #45586
Assignees
@gigitux
Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. plugin: woocommerce Issues related to the WooCommerce Core plugin. team: Kirigami & Origami type: bug The issue is a confirmed bug.

Comments

@gigitux
Copy link
Contributor

gigitux commented Mar 13, 2024 •
edited

After clicking "Start Designing" the wp-admin screen and a spinner are visible for a moment. Check this video:

BDGZbv.mp4

It looks like that we introduced a regression with the last PRs because with an old version of the trunk, it doesn't happen.

  1. Create a new WooCommerce installation with this version.
  2. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  3. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  4. Visit the wp-admin/admin.php?page=wc-admin&path=/customize-store.
  5. Click on the "Start Designing" button.
  6. See wp-admin screen and a spinner visible for a moment.
@gigitux gigitux added type: bug The issue is a confirmed bug. focus: customize-your-store Issues related to the Customize Your Store onboarding flow. team: Kirigami & Origami labels Mar 13, 2024
@gigitux gigitux mentioned this issue Mar 13, 2024
Open
@nefeline nefeline added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 13, 2024
@gigitux gigitux self-assigned this Mar 14, 2024
@gigitux gigitux mentioned this issue Mar 14, 2024
Merged
11 tasks
@gigitux gigitux linked a pull request Mar 14, 2024 that will close this issue
CYS - Core: fix wp-admin page visible when click on start designing #45586
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gigitux gigitux

Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. plugin: woocommerce Issues related to the WooCommerce Core plugin. team: Kirigami & Origami type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
2 participants
@gigitux @nefeline