Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYS - Core: fix wp-admin page visible when click on start designing #45586

Conversation

gigitux
Copy link
Contributor

@gigitux gigitux commented Mar 14, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #45542.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Make sure you have the WooCommerce Beta Tester plugin installed and activated
  2. Under Tools > WCA Test Helper > Features, make sure customize-store is enabled
  3. Under Tools > WCA Test Helper > Tools, click on Reset Customize Your Store
  4. Head over to WooCommerce > Extensions > Themes wp-admin/admin.php?page=wc-admin&tab=themes&path=%2Fextensions
  5. Make sure you can visualize the Design your own button. If the current active theme is TT4, it directs users to the assembler, if not, the theme switch warning modal is displayed to confirm the user wants to proceed to the CYS flow and change their current active theme.
  6. Click on wp-admin/admin.php?page=wc-admin&path=%2Fcustomize-store%2Fintro.
  7. Start the flow.
  8. Ensure that the wp-admin page isn't visible for a second (check the video attached to the issue).
  9. Go on /wp-admin
  10. Under Tools > WCA Test Helper > Tools, click on Reset Customize Your Store
  11. Switch to TT3.
  12. Start the flow.
  13. Ensure that the wp-admin page isn't visible for a second (check the video attached to the issue).

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

CYS - Core: fix wp-admin page visible when click on start designing

Comment

@gigitux gigitux added type: bug The issue is a confirmed bug. team: Kirigami & Origami focus: customize-your-store Issues related to the Customize Your Store onboarding flow. labels Mar 14, 2024
@gigitux gigitux self-assigned this Mar 14, 2024
@gigitux gigitux requested a review from nefeline March 14, 2024 13:11
@woocommercebot woocommercebot requested a review from a team March 14, 2024 13:11
@gigitux gigitux requested review from albarin and removed request for a team March 14, 2024 13:11
Copy link
Contributor

github-actions bot commented Mar 14, 2024

Hi @nefeline,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Mar 14, 2024

Test Results Summary

Commit SHA: 703845a

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 39s
E2E Tests801027103528m 58s

⚠️ Warning

Please address the following issues prior to merging this pull request:
  • FAILED/BROKEN TESTS. There were failed and/or broken API and E2E tests.

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 14, 2024
Copy link
Contributor

@albarin albarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏
Confirmed the admin page is longer visible.

@gigitux gigitux enabled auto-merge (squash) March 14, 2024 15:21
@gigitux gigitux merged commit 21d4fd7 into trunk Mar 15, 2024
28 of 30 checks passed
@gigitux gigitux deleted the 45542-cys-core-wp-admin-screen-visible-for-a-moment-after-clicking-start-designing-1 branch March 15, 2024 08:17
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 15, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 15, 2024
@veljkho veljkho added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYS - Core]: wp-admin screen visible for a moment after clicking "Start Designing"
3 participants