Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CYS on Core] Product rating block not rendering #45593

Closed
Tracked by #43623
nefeline opened this issue Mar 14, 2024 · 3 comments · Fixed by #45600
Closed
Tracked by #43623

[CYS on Core] Product rating block not rendering #45593

nefeline opened this issue Mar 14, 2024 · 3 comments · Fixed by #45600
Assignees
@gigitux
Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. plugin: woocommerce Issues related to the WooCommerce Core plugin. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. team: Kirigami & Origami type: bug The issue is a confirmed bug.

Comments

@nefeline
Copy link
Member

Issue Description:

This is a spinoff of #45475 : while that issue ended up being a regression on WP 6.5, this one is focused on investigating a problem that is preventing the Product Rating block from working as expected:

Steps to reproduce

  1. Make sure you have the WooCommerce Beta Tester plugin installed and activated
  2. Under Tools > WCA Test Helper > Features, make sure customize-store is enabled
  3. Under Tools > WCA Test Helper > Tools, click on Reset Customize Your Store and Delete all products
  4. Head over to WooCommerce > Home > Customize your store
  5. Click on "Start designing" and proceed to the Pattern Assembler
  6. On the initial screen, scroll down and notice how the Product Rating block is throwing the following error:
Screenshot 2024-03-14 at 15 51 55
@nefeline nefeline added type: bug The issue is a confirmed bug. focus: customize-your-store Issues related to the Customize Your Store onboarding flow. plugin: woocommerce Issues related to the WooCommerce Core plugin. team: Kirigami & Origami labels Mar 14, 2024
@nefeline nefeline mentioned this issue Mar 14, 2024
Open
@nefeline nefeline added the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Mar 14, 2024
@gigitux
Copy link
Contributor

gigitux commented Mar 14, 2024

It looks like in some cases (I'm still not able to define them), the JS related to the Product Rating block is not enqueued:

Bug No Bug
image image

I'm continuing to investigate.

@gigitux
Copy link
Contributor

gigitux commented Mar 14, 2024

The issue is replicable when jetpack is installed

@gigitux
Copy link
Contributor

gigitux commented Mar 14, 2024

I was able to narrow the issue. It is reproducible with Jetpack installed. The PR that introduced this regression is: #45196

@gigitux gigitux self-assigned this Mar 14, 2024
@gigitux gigitux mentioned this issue Mar 14, 2024
Merged
11 tasks
@gigitux gigitux linked a pull request Mar 14, 2024 that will close this issue
CYS - Core: fix Product Rating block renders #45600
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gigitux gigitux

Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. plugin: woocommerce Issues related to the WooCommerce Core plugin. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. team: Kirigami & Origami type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CYS - Core: fix Product Rating block renders woocommerce/woocommerce
2 participants
@gigitux @nefeline