Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYS - Core: fix Product Rating block renders #45600

Merged
merged 4 commits into from Mar 15, 2024

Conversation

gigitux
Copy link
Contributor

@gigitux gigitux commented Mar 14, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This regression has been introduced with #45196, and it is reproducible only when JetPack is installed.
I'm not sure why this happens, but I guess that getEditedPostType triggers the rendering of the Editor, and this fixes the issue.

Closes #45593.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Make sure you have the WooCommerce Beta Tester plugin installed and activated.
  2. Ensure you have Jetpack plugin installed.
  3. Under Tools > WCA Test Helper > Features, make sure customize-store is enabled.
  4. Under Tools > WCA Test Helper > Tools, click on Reset Customize Your Store.
  5. Head over to WooCommerce > Home > Customize your store.
  6. Click on "Start designing" and proceed to the Pattern Assembler.
  7. Ensure that this error is not visible:
    image
  8. Instead, ensure that the Product Rating is visible.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

CYS - Core: fix Product Rating block renders

Comment

@gigitux gigitux added type: bug The issue is a confirmed bug. team: Kirigami & Origami focus: customize-your-store Issues related to the Customize Your Store onboarding flow. labels Mar 14, 2024
@gigitux gigitux self-assigned this Mar 14, 2024
@gigitux gigitux linked an issue Mar 14, 2024 that may be closed by this pull request
@woocommercebot woocommercebot requested a review from a team March 14, 2024 18:05
Copy link
Contributor

github-actions bot commented Mar 14, 2024

Hi @albarin, @nefeline, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Mar 14, 2024

Test Results Summary

Commit SHA: 3026b12

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests299005403537m 43s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@danielwrobert danielwrobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run through the test plan and everything works as expected.

  • No error is present below the product items.
  • The Product Rating is visible.
  • When there is no rating, a "No Reviews" message is shown in it's place.

CleanShot 2024-03-14 at 17 10 20

The code LGTM as well. Thanks for working on this!

Copy link
Member

@nefeline nefeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! 🚀

…-cys-on-core-product-rating-block-not-rendering
@gigitux gigitux enabled auto-merge (squash) March 15, 2024 16:17
@gigitux gigitux disabled auto-merge March 15, 2024 16:58
@gigitux gigitux enabled auto-merge (squash) March 15, 2024 16:59
@gigitux gigitux merged commit 25c804a into trunk Mar 15, 2024
27 of 28 checks passed
@gigitux gigitux deleted the 45593-cys-on-core-product-rating-block-not-rendering branch March 15, 2024 17:01
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 15, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 15, 2024
@alopezari alopezari added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYS on Core] Product rating block not rendering
4 participants