New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CYS - Core: fix Product Rating block renders #45600
CYS - Core: fix Product Rating block renders #45600
Conversation
Hi @albarin, @nefeline, @woocommerce/woo-fse Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 3026b12
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! 🚀
…-cys-on-core-product-rating-block-not-rendering
Submission Review Guidelines:
Changes proposed in this Pull Request:
This regression has been introduced with #45196, and it is reproducible only when JetPack is installed.
I'm not sure why this happens, but I guess that
getEditedPostType
triggers the rendering of the Editor, and this fixes the issue.Closes #45593.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Significance
Type
Message
CYS - Core: fix Product Rating block renders
Comment