You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
BlockTemplatesController is a class used to handle block templates and templates parts.
While several of its methods check for the theme to support block templates/block templates parts before running, there are several other methods which don't have those checks, which is easy to cause bugs (see #46429 and #46461).
This issue is about try to only initialize BlockTemplatesController when the theme supports block templates or block template parts. So BlockTemplatesController wouldn't be initialized in classic themes at all.
One challenge is that the check_should_use_blockified_product_grid_templates method needs to be run also in classic themes, so it should be moved out of this class:
Blocked by #46464.
BlockTemplatesController
is a class used to handle block templates and templates parts.While several of its methods check for the theme to support block templates/block templates parts before running, there are several other methods which don't have those checks, which is easy to cause bugs (see #46429 and #46461).
This issue is about try to only initialize
BlockTemplatesController
when the theme supports block templates or block template parts. SoBlockTemplatesController
wouldn't be initialized in classic themes at all.One challenge is that the
check_should_use_blockified_product_grid_templates
method needs to be run also in classic themes, so it should be moved out of this class:woocommerce/plugins/woocommerce/src/Blocks/BlockTemplatesController.php
Lines 217 to 235 in de54195
The text was updated successfully, but these errors were encountered: