Fix wrong Shop title shown in classic themes after deleting the page #46429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
focus: template
woocommercebot
requested review from
a team and
samueljseay
and removed request for
a team
github-actions
bot
added
the
plugin: woocommerce
|
Hi @samueljseay, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Aljullu
deleted the
fix/wrong-shop-title-after-deletion-in-classic-themes
branch
github-actions
bot
added
the
needs: analysis
This was referenced Apr 10, 2024
nigeljamesstevenson
added
needs: internal testing
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
…46429) * Fix wrong Shop title shown in classic themes after deleting the page * Add changelog file * Add explanatory comment
This was referenced Apr 11, 2024
rodelgc
pushed a commit
that referenced
this pull request
Apr 11, 2024
* Fix wrong Shop title shown in classic themes after deleting the page (#46429) * Fix wrong Shop title shown in classic themes after deleting the page * Add changelog file * Add explanatory comment * Prep for cherry pick 46429 --------- Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> Co-authored-by: WooCommerce Bot <no-reply@woo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR partially reverts some changes introduced in #44537.
Rationale: we had some code that made sure the Shop page title was Shop. While we initially wrote that code to be applied only to block themes, given that
BlockTemplatesControllerwas run also in classic themes, it caused the change to apply to classic themes as well. When we moved that logic to theProductCatalogTemplateclass in #44537, it stopped being run in classic themes, causing the regression.This PR moves the code back to
BlockTemplatesControllerto make sure it runs in classic themes as well.This is a temporary solution. If this code is expected to run in classic and block themes, ideally it shouldn't be in
BlockTemplatesController.Kudos to @jorgeatorres for finding the root of the issue!
How to test the changes in this Pull Request:
/shop).<title>tags, that means the title that appears in the tab bar.Changelog entry
Significance
Type
Message
Comment