Extra argument in emails/customer-new-account.php

[MadSpaniard]

In WC2.1.2: A very minor issue in the HTML email templates:

In the file "emails/customer-new-account.php"" on line #18 there are 2 arguments specified but only the 1st is used in the printf output. Seems the 1st argument "esc_html( $blogname )" should be removed as the 2nd one is intended for the printf output (perhaps line #18 was modeled after line #14 where both arguments are utilized, but the blogname isn't needed on line 18).

Note: the corresponding plain email template file "emails/plain/customer-new-account.php" is fine.

[mikejolley]

Mistaken I think:

printf( __( "Thanks for creating an account on %s. Your username is <strong>%s</strong>.", 'woocommerce' ), esc_html( $blogname ), esc_html( $user_login ) );

There are 2 %s

[MadSpaniard]

Are you referring to line #14 or #18? I'm looking at #18 which is this:

printf( __( "Your password has been automatically generated: %s", 'woocommerce' ), esc_html( $blogname ), esc_html( $user_pass ) ); 

[MadSpaniard]

Hello Mike -

I just added a follow-up comment to issue #4802 which you closed.

Issue:
#4802

I’m referring to line #18 in emails/customer-new-account.php which is this line, seems to have only 1 %s but 2 arguments (blogname, user_pass):

%s", 'woocommerce' ), esc_html( $blogname ), esc_html( $user_pass ) ); ?>

Thanks for your help,