[Product CRUD] Product Datastore #12317

justinshreve · 2016-11-11T12:07:40Z

Phew. This PR introduces datastore classes for products. This includes moving things like queries from wc-product-functions.php as well, so things are pluggable and can be updated.

This PR also fixes up some tests that were failing on the product-crud branch. All test files in unit-tests/product/* pass now!

…d general data store updates for products.

…nterface for the public variable methods.

mikejolley

Added my feedback :) 🎉

mikejolley · 2016-11-11T12:32:40Z

includes/class-wc-structured-data.php

@@ -202,7 +202,7 @@ public function generate_product_data( $product = null ) {
 					'availability'  => 'http://schema.org/' . $stock = ( $_product->is_in_stock() ? 'InStock' : 'OutOfStock' ),
 					'sku'           => $_product->get_sku(),
 					'image'         => wp_get_attachment_url( $_product->get_image_id() ),
-					'description'   => $is_variable ? $_product->get_variation_description() : '',
+					'description'   => $is_variable ? $_product->get_description() : '',


Why is this just for variations I wonder?

mikejolley · 2016-11-11T12:34:39Z

includes/data-stores/class-wc-product-data-store-cpt.php

+		$product->set_date_created( current_time( 'timestamp' ) );
+
+		$id = wp_insert_post( apply_filters( 'woocommerce_new_product_data', array(
+			'post_type'      => $product->post_type,


Is this maybe something that only the data store should care about?

mikejolley · 2016-11-11T12:35:25Z

includes/data-stores/class-wc-product-data-store-cpt.php

+
+		if ( ! $product->get_id() || ! ( $post_object = get_post( $product->get_id() ) ) ) {
+			throw new Exception( __( 'Invalid product.', 'woocommerce' ) );
+			return;


Don't think the return will ever execute.

mikejolley · 2016-11-11T12:37:57Z

includes/data-stores/class-wc-product-data-store-cpt.php

+	*/
+
+	/**
+	 * <Description>


mikejolley · 2016-11-11T12:39:09Z

includes/data-stores/class-wc-product-data-store-cpt.php

+	 * @param string $sku Will be slashed to work around https://core.trac.wordpress.org/ticket/27421
+	 * @return bool
+	 */
+	public function sku_found( $product_id, $sku ) {


is_existing_sku might be more clear that it's a conditonal.

mikejolley · 2016-11-11T12:44:18Z

includes/data-stores/class-wc-product-variation-data-store-cpt.php

+	 */
+	public function update_post_meta( $product ) {
+		update_post_meta( $product->get_id(), '_variation_description', $product->get_description() );
+		$product = parent::update_post_meta( $product );


Would it be cleaner to pass by reference rather than pass the $product object around? I don't know the answer - I just notice you used a mixture of both approaches throughout the PR.

mikejolley · 2016-11-11T12:46:49Z

includes/wc-product-functions.php

@@ -84,7 +84,7 @@ function wc_get_products( $args ) {
 	 * Generate WP_Query args.
 	 */
 	$wp_query_args = array(
-		'post_type'      => 'variation' === $args['type'] ? 'product_variation' : 'product',
+		'post_type'      => array( 'product', 'product_variation' ),


This has reverted a change I made earlier. See lines 100 - 104 too. variations do not have 'types' - I don't even think they are linked to the taxonomy. I think this change will make the tax_query fail.

Was there a reason you changed it back?

@mikejolley I changed it back so you can get both products and product variations in one go -- but maybe that's not something we want.

Hmm, I don't think we need it now, but it won't work anyway unless we add the taxonomy to product_variation post type and handle bw comp. Not worth it?

Yeah doesn't seem worth it right now.

mikejolley · 2016-11-11T12:47:51Z

includes/wc-product-functions.php

-	$product_ids_on_sale = array_unique( array_map( 'absint', array_merge( wp_list_pluck( $on_sale_posts, 'ID' ), array_diff( wp_list_pluck( $on_sale_posts, 'post_parent' ), array( 0 ) ) ) ) );
+	$data_store          = WC_Data_Store::load( 'product' );
+	$on_sale_products    = $data_store->get_on_sale_products();
+	$product_ids_on_sale = array_unique( array_map( 'absint', array_merge( wp_list_pluck( $on_sale_products, 'id' ), array_diff( wp_list_pluck( $on_sale_products, 'parent_id' ), array( 0 ) ) ) ) );


We can use that parse int list function here.

mikejolley · 2016-11-11T12:48:47Z

includes/wc-product-functions.php

-
-				if ( $this_product->is_type( 'simple' ) ) {
-					$this_product->grouped_product_sync();
+				if ( $product->is_type( 'simple' ) ) {


Just a note, I need to go over the grouped sync at some point and review if needed.

mikejolley · 2016-11-11T12:50:09Z

includes/wc-product-functions.php

@@ -1297,58 +1163,6 @@ function wc_products_array_orderby_price( $a, $b ) {
 * @return int Matching variation ID or 0.
 */
 function wc_find_matching_product_variation( $product, $match_attributes = array() ) {


This was a new method I added in 2.7 - do we need it anymore?

mikejolley · 2016-11-11T14:31:10Z

🎈

coderkevin · 2016-11-11T15:36:49Z

👍

@claudiosanches

* Created function to get the catalog visibility options * First methods for WP_Product crud * Product set methods * Fixed several erros while setting data * First methods for WP_Product crud * Product set methods * Fixed several erros while setting data * Hardcode the get_type per product class * Initial look through getters and setters and abstract data * Missing var * Add related product functions and deprecate those in class. * No need to exclude ID * Fixed coding standards and improved the docblocks * Get cached terms from wc_get_related_terms() * Fixed wrong variable in wc_get_related_terms * Use count() instead of sizeof() * Sanitize ids later * Remove unneeded comments * wc_get_product_term_ids instead of related wording and use in other places. get_the_terms is used here and also handles caching, something wp_get_post_terms does not. * Clean up the abstract product class a bit, deprecate two functions we have renamed, make update & create work properly, and add some tests for it. * Bump template version * Handle PR feedback: Remove duplicate regular_price update, allow changing of post status for products, remove deprecation for get_title since we might still offer it as a function * Made abstract function useful * External Product CRUD * _virtual meta should be 'no', not taxable, in product unit test helper * Grouped product class * Tests * Move children to meta and update test * Use get_upsell_ids * Spacing in query * Moving and refactoring methods * Availability html * Tidy/add todos * Rename method * Put back review functions (still todo) * missing $this * get_price_including_tax/excluding_tax functions * wc_get_price_to_display * Price handling * [Product CRUD] Variable (#12146) * [Product CRUD] Variable Products * Handle PR feedback. * [Product CRUD] Grouped Handling (#12151) * Handle grouped product saving * Update routine * [Product CRUD] Product crud terms (#12149) * Category and tag id handling * Replace template functions * Remove todo * Handle default name in save function * Product crud admin save routine (#12174) * Initial props * Work on admin saving * Set/get attributes * Atom was moaning about this before but no longer. * Update get_shipping_class * WC_Product_Attribute * Use getter in admin panel * Fix attribute saving * Spacing * Fix comment * wc_implode_text_attributes helper function * [Product CRUD] Product crud admin use getters (#12196) * Initial props * Work on admin saving * Set/get attributes * Atom was moaning about this before but no longer. * Update get_shipping_class * WC_Product_Attribute * Use getter in admin panel * Fix attribute saving * Move settings into new files * Refactor panels and use getters * Use getters for variation panel * Revert save variation changes for now * Add todos * Fix downloads * REST API CRUD Updates * Additional API updates/fixes. Added some todos * Fix final failing tests and implementing setters/getters and attributes functionality. * Fix comparison for is_on_sale and remove download_type from WC_Product. * Add a wc_get_products wrapper. * Remove the download type input from the product data metabox for downloadable products. (#12221) * [Product CRUD] Variations - setters, getters and admin. (#12228) * Started on variation changes * Stock functions * Variation class * Bulk change ->id to get_id() to fix variation form display * Missing status * Fix add to cart * Start on stored data save * save variation * Save_variations * Variation edit panel * Save variations code works. * Remove stored data code and fix save * Improve legacy class * wc_bool_to_string * prepare_set_attributes * Use wc_get_products * More feedback fixes * Feedback fixes * Implement CRUD in the legacy REST API * Handle PR feedback * [Product CRUD] Getter setter proxy methods (#12236) * Started on variation changes * Stock functions * Variation class * Bulk change ->id to get_id() to fix variation form display * Missing status * Fix add to cart * Start on stored data save * save variation * Save_variations * Variation edit panel * Save variations code works. * Remove stored data code and fix save * Improve legacy class * wc_bool_to_string * prepare_set_attributes * Use wc_get_products * More feedback fixes * get_prop implementation in abstract and data classes * Implement set_prop * Change handling * Array key exists * set_object_read * Use get_the_terms() instead of wp_get_post_terms() wp_get_post_terms() is a wrapper around wp_get_object_terms() which does not use the object cache, and generates a database query every time it is used. get_the_terms() however can use data from the object cache if present. * Allow WP_Query to preload post data, and meta in wc_get_products() Allow WP_Query to bulk query for post data and meta if more than just IDs are requested from wc_get_products(). Reduces query count significantly. * [Product CRUD] Variable, variation, notices, and stock handling (#12277) * No longer needed * Remove old todos * Use getters in admin list * Related and upsells update for CRUD * Fix notice in gallery * Variable fixes and todos * Context * Price sync * Revert variation attributes change * Return parent data in view context * Defer term counting * wc_find_matching_product_variation * Stock manage tweaks * Stock fixes * Correct id * correct id * Better sync * Data logic setter fix * feedback * First methods for WP_Product crud * Product set methods * Fixed several erros while setting data * Hardcode the get_type per product class * Initial look through getters and setters and abstract data * Missing var * Fixed coding standards and improved the docblocks * Get cached terms from wc_get_related_terms() * Fixed wrong variable in wc_get_related_terms * Use count() instead of sizeof() * Add related product functions and deprecate those in class. * No need to exclude ID * Sanitize ids later * Clean up the abstract product class a bit, deprecate two functions we have renamed, make update & create work properly, and add some tests for it. * Remove unneeded comments * wc_get_product_term_ids instead of related wording and use in other places. get_the_terms is used here and also handles caching, something wp_get_post_terms does not. * Handle PR feedback: Remove duplicate regular_price update, allow changing of post status for products, remove deprecation for get_title since we might still offer it as a function * External Product CRUD * _virtual meta should be 'no', not taxable, in product unit test helper * Bump template version * Made abstract function useful * Grouped product class * Tests * Move children to meta and update test * Use get_upsell_ids * Spacing in query * Moving and refactoring methods * Availability html * Tidy/add todos * Rename method * Put back review functions (still todo) * missing $this * get_price_including_tax/excluding_tax functions * wc_get_price_to_display * Price handling * [Product CRUD] Variable (#12146) * [Product CRUD] Variable Products * Handle PR feedback. * [Product CRUD] Grouped Handling (#12151) * Handle grouped product saving * Update routine * [Product CRUD] Product crud terms (#12149) * Category and tag id handling * Replace template functions * Remove todo * Handle default name in save function * Product crud admin save routine (#12174) * Initial props * Work on admin saving * Set/get attributes * Atom was moaning about this before but no longer. * Update get_shipping_class * WC_Product_Attribute * Use getter in admin panel * Fix attribute saving * Spacing * Fix comment * wc_implode_text_attributes helper function * [Product CRUD] Product crud admin use getters (#12196) * Initial props * Work on admin saving * Set/get attributes * Atom was moaning about this before but no longer. * Update get_shipping_class * WC_Product_Attribute * Use getter in admin panel * Fix attribute saving * Move settings into new files * Refactor panels and use getters * Use getters for variation panel * Revert save variation changes for now * Add todos * Fix downloads * REST API CRUD Updates * Additional API updates/fixes. Added some todos * Fix final failing tests and implementing setters/getters and attributes functionality. * Fix comparison for is_on_sale and remove download_type from WC_Product. * Add a wc_get_products wrapper. * Remove the download type input from the product data metabox for downloadable products. (#12221) * [Product CRUD] Variations - setters, getters and admin. (#12228) * Started on variation changes * Stock functions * Variation class * Bulk change ->id to get_id() to fix variation form display * Missing status * Fix add to cart * Start on stored data save * save variation * Save_variations * Variation edit panel * Save variations code works. * Remove stored data code and fix save * Improve legacy class * wc_bool_to_string * prepare_set_attributes * Use wc_get_products * More feedback fixes * Feedback fixes * Implement CRUD in the legacy REST API * Handle PR feedback * [Product CRUD] Getter setter proxy methods (#12236) * Started on variation changes * Stock functions * Variation class * Bulk change ->id to get_id() to fix variation form display * Missing status * Fix add to cart * Start on stored data save * save variation * Save_variations * Variation edit panel * Save variations code works. * Remove stored data code and fix save * Improve legacy class * wc_bool_to_string * prepare_set_attributes * Use wc_get_products * More feedback fixes * get_prop implementation in abstract and data classes * Implement set_prop * Change handling * Array key exists * set_object_read * Use get_the_terms() instead of wp_get_post_terms() wp_get_post_terms() is a wrapper around wp_get_object_terms() which does not use the object cache, and generates a database query every time it is used. get_the_terms() however can use data from the object cache if present. * [Product CRUD] Variable, variation, notices, and stock handling (#12277) * No longer needed * Remove old todos * Use getters in admin list * Related and upsells update for CRUD * Fix notice in gallery * Variable fixes and todos * Context * Price sync * Revert variation attributes change * Return parent data in view context * Defer term counting * wc_find_matching_product_variation * Stock manage tweaks * Stock fixes * Correct id * correct id * Better sync * Data logic setter fix * feedback * Prevent notices * Handle image_id from parent * Fix error * Remove _wc_save_product_price * Remove todo * Fixed wrong variation URLs * Fixed undefined $image_id in WC_Product_Variation::get_image_id() * Allow wc_rest_prepare_date_response() handle timestamps * Updated get methods on REST API for variations * Use variations CRUD to save variations metadata * [Product CRUD] Abstract todos (#12305) * Get dimensions and weights, with soft deprecation * Product attributes * Ratings * Fix read method * Downloads * Feedback * Revert "[Product CRUD] Abstract todos (#12305)" This reverts commit 9a6136f. * Remove deprecated get_variation_id() * New default attributes method * [Product CRUD] Product Datastore (#12317) * Fix up tests in the product/* folder. * Handle data store updates for grouped, variable, external, simple, and general data store updates for products. * Variations & variable changes. * Update -functions.php calls to use data store. * Add an interface for the public product data store methods. * Finished product factory tests * Correctly delete in the api, fix up some comments, and implement an interface for the public variable methods. * Fix up delete in all versions of the api * Handle feedback * Match protected decloration to parent * Product crud abstract todos (#12316) * Get dimensions and weights, with soft deprecation * Product attributes * Ratings * Fix read method * Downloads * Feedback * Fix up store * Fixed method returning in write context * Fix error in variation admin * Check for parent value - fixes tax class * Remove old/complete todos * Allow set tax class as "parent" * Removed duplicated sync * Fixed wrong variation URLs * Fixed undefined $image_id in WC_Product_Variation::get_image_id() * Allow wc_rest_prepare_date_response() handle timestamps * Updated get methods on REST API for variations * Use variations CRUD to save variations metadata * Remove deprecated get_variation_id() * New default attributes method * Fixed method returning in write context * Allow set tax class as "parent" * Removed duplicated sync * Fixed coding standards * TODO is not accurate. * Should pass WC_Product instancies to WC_Comments methods (#12327) * Use new method in abstract order class to prevent headers sent issue in tests * Fixed variable description in REST API * Updated how create initial product variation * Fixed a few fatal errors and warnings in Products CRUD (#12329) * Fixed a few fatal errors and warnings in Products CRUD * Fixed sync functions * Add variations CRUD to legacy API (#12331) * Apply crud to variable products in legacy API v1 * New REST API do not need fallback for default attributes * Apply variations CRUD to legacy API v2 * Legacy v2 - save default attributes * Variations in legacy API v2 do not have descriptions * Fixed legacy API v2 variations params * Applied variations CRUD to legacy API v3 * Sync before save in legacy apis * Punc * Removed API todos * Removed test * Products endpoint tweaks (#12354) * Var type already normalized on CRUD * Let Product CRUD handle with validation, sanitization and conditional checks * Set downloads using WC_Product_Download * Stop try catch exceptions more than one time * Handle WC_Data_Exception in legacy API * Complete remove products when fails on creating * On creating I mean! * Already have a method to complete delete products * Fixed standards using WP CodeSniffer * get_the_terms() returns false when empty * get_manage_stock returns boolean @claudiosanches * Merge conflict * Variations API endpoint fixes * Product CRUD improvements (#12359) * args is not used any more - remove todo * Added test for attributes * wc_get_price_excluding_tax usage * parent usage * Fix rating counts * Test fixes * Cleanup after tests * Make sure status transition code runs even during API calls, not just in admin. * Default visibility * Fix attribute setting in API * Use get name instead of get title * variation id usage * Improved cross sell templates * variation_data * Grouped product sync * Notices * Sync is not needed in API * Delete * Rename interfaces * Update counts in data store

justinshreve added 8 commits November 10, 2016 02:08

Fix up tests in the product/* folder.

d0161b3

Handle data store updates for grouped, variable, external, simple, an…

eb1b421

…d general data store updates for products.

Variations & variable changes.

2e4adad

Update -functions.php calls to use data store.

888ef50

Add an interface for the public product data store methods.

8d80781

Finished product factory tests

1c6f432

Correctly delete in the api, fix up some comments, and implement an i…

cc0985e

…nterface for the public variable methods.

Fix up delete in all versions of the api

6366f61

justinshreve added type: refactor The issue/PR is related to refactoring. [Status] Needs Review labels Nov 11, 2016

justinshreve added this to the 2.7 milestone Nov 11, 2016

justinshreve self-assigned this Nov 11, 2016

mikejolley requested changes Nov 11, 2016

View reviewed changes

mikejolley added needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. and removed [Status] Needs Review labels Nov 11, 2016

justinshreve added 2 commits November 11, 2016 05:33

Handle feedback

2d03051

Match protected decloration to parent

e318bb7

justinshreve added [Status] Needs Review and removed needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. labels Nov 11, 2016

mikejolley added [Status] Ready to Merge and removed [Status] Needs Review labels Nov 11, 2016

mikejolley merged commit 90e43d9 into product-crud Nov 11, 2016

mikejolley deleted the product-datastore branch November 11, 2016 16:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Product CRUD] Product Datastore #12317

[Product CRUD] Product Datastore #12317

justinshreve commented Nov 11, 2016

mikejolley left a comment

mikejolley Nov 11, 2016

mikejolley Nov 11, 2016

mikejolley Nov 11, 2016

mikejolley Nov 11, 2016

mikejolley Nov 11, 2016

mikejolley Nov 11, 2016

mikejolley Nov 11, 2016

justinshreve Nov 11, 2016

mikejolley Nov 11, 2016

justinshreve Nov 11, 2016

mikejolley Nov 11, 2016

mikejolley Nov 11, 2016

mikejolley Nov 11, 2016

mikejolley commented Nov 11, 2016

coderkevin commented Nov 11, 2016

[Product CRUD] Product Datastore #12317

[Product CRUD] Product Datastore #12317

Conversation

justinshreve commented Nov 11, 2016

mikejolley left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mikejolley commented Nov 11, 2016

coderkevin commented Nov 11, 2016