Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wc_update_300_grouped_products update routine needs to unset the post_parent on grouped products #14521

Merged
merged 1 commit into from Apr 19, 2017

Conversation

mikejolley
Copy link
Member

Fixes #14507

@mikejolley mikejolley added this to the 3.0.4 milestone Apr 19, 2017
@mikejolley
Copy link
Member Author

Just flagging this up with your @thenbrent to make sure you're not relying on this anymore after update.

@claudiulodro
Copy link
Contributor

This looks good on my end. 👍

@thenbrent
Copy link
Contributor

Just flagging this up with your @thenbrent to make sure you're not relying on this anymore after update.

@mikejolley we're not relying on it anymore.

I do notice this only updates stores updating from < 3.0.0. What about stores that are upgrading from 3.0.n to 3.0.4+, the parent_id will still be set if they updated in the first couple of weeks. Is that considered OK or an oversight?

@mikejolley
Copy link
Member Author

I did not want another DB update in a fix release as it would be shown to all users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants