Send headers when shutting down. #16158
Conversation
| session_write_close(); | ||
| } | ||
|
|
||
| // This is the cleanest approuch when available and is used on nginx. |
There was a problem hiding this comment.
Typo approuch. Also, it's not exclusive to nginx, it's part of the php-fpm package which can be installed as an Apache module too (it just happens that my installation doesn't include it by default). I think it's enough to say that "it isn't always present".
| @@ -23,6 +23,9 @@ class WC_API extends WC_Legacy_API { | |||
| public function __construct() { | |||
| parent::__construct(); | |||
|
|
|||
| // Wrangle long requests. | |||
| add_action( 'shutdown', array( $this, 'rest_send_reponse_before_shutdown' ), -1 ); | |||
There was a problem hiding this comment.
Wouldn't it make more sense to add this to Jetpack instead, since the slow shutdown hooks are inside Jetpack? @beaulebens ?
There was a problem hiding this comment.
If the slowdown is coming from Jetpack then yes, certainly we want to fix it there.
|
|
||
| // For apache, send some headers. | ||
| } else { | ||
| header( 'Content-Length: ' . ob_get_length() ); |
There was a problem hiding this comment.
You probably want to wrap these in a headers_sent() check, otherwise it'll throw errors if any output has already been sent.
There was a problem hiding this comment.
@beaulebens line 52, along with checks to ensure this is a REST api request.
|
Logged on trac https://core.trac.wordpress.org/ticket/41358#ticket |
|
Submitted a patch to core https://core.trac.wordpress.org/ticket/41358#comment:1 |
Sends headers on the shutdown hook so expensive shutdown actions do not slow things down with the REST API.
e.g. adding a product, on shutdown there may be sync events. This ensures the response was sent before that happens.