Updates screen modal. #16324
Merged
Updates screen modal. #16324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm just going to merge this into the feature branch and work off that. We can just review everything when ready; it shouldn't be too big of a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15478 and #16086.
I think this way should work well and play nicely with other stuff out there that does stuff to the bulk updates screen.
If the user checks the WC checkbox or the "Select All" checkbox, a modal is displayed if there are untested plugins with the new major release:
If the user clicks "cancel", the WC checkbox unchecks:
If they click "accept", the WC checkbox stays checked.