Download reporting #17679
Merged
Download reporting #17679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Order details Downloads section
…ings on order details page
…d with static UUID instead of filename based hash, to preserve download links, logs, and permissions across filename changes
…e for PHP 5.2 compat
… ready for merging
…wnload count and proper escaping on report links
… log report titles in standalone function, reorganize download log data store read for code readability
…and downloads remaining in SQL to avoid race conditions with updating in PHP
… download log ids should no longer change based on file paths
…THOD__ instead of hard coded function name
…load_paths since download ids should no longer change. They are now static UUIDs.
Codecov Report
@@ Coverage Diff @@
## master #17679 +/- ##
============================================
+ Coverage 34.89% 34.9% +<.01%
- Complexity 12197 12286 +89
============================================
Files 332 336 +4
Lines 50016 50400 +384
============================================
+ Hits 17455 17591 +136
- Misses 32561 32809 +248
Continue to review full report at Codecov.
|
mikejolley
added
Status: Needs Review
and removed
status: in progress
|
Deprecation notices are breaking a bunch of the tests: https://travis-ci.org/woocommerce/woocommerce/jobs/301563517 |
| @@ -560,7 +560,7 @@ private static function get_schema() { | |||
| ) $collate; | |||
| CREATE TABLE {$wpdb->prefix}woocommerce_downloadable_product_permissions ( | |||
| permission_id BIGINT UNSIGNED NOT NULL auto_increment, | |||
| download_id varchar(32) NOT NULL, | |||
| download_id varchar(36) NOT NULL, | |||
There was a problem hiding this comment.
Do we need an update script for this, too? Otherwise old DBs won't properly handle the new download IDs?
|
Looks good and works well. Just a question and the tests need fixing. |
claudiulodro
added
needs: author feedback
mikejolley
added
Status: Needs Review
and removed
needs: author feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #16418
TODO: