Importer/Exporter backorder compatibility #17875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
mikejolley
requested changes
Nov 23, 2017
| * @return string | ||
| */ | ||
| protected function unescape_negative_number( $value ) { | ||
| $unescaped = str_replace( "'-", '-', $value ); |
There was a problem hiding this comment.
This could use some improvement because it will replace at any point in the string. We only want to remove if it's at the beginning of the string.
mikejolley
added
needs: author feedback
claudiulodro
removed
the
needs: author feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #11259
Adds a
backorderoption to the'In stock?'CSV importer/exporter field. After this is merged the available options will be0,1, andbackorder.Also fixes a bug where negative numbers weren't working properly in the importer because of the
'prepended to the number.To test: create a product with the backorder status, export a CSV, then import the generated CSV (exclude ID and SKU fields when importing to create new products).