Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR - Personal data export and removal #19330

Merged
merged 20 commits into from Apr 17, 2018
Merged

Conversation

mikejolley
Copy link
Member

@mikejolley mikejolley commented Mar 9, 2018

This PR integrates WooCommerce with the patch proposed in https://core.trac.wordpress.org/ticket/43546 You'll need to be running the development branch with that patch applied to see this in action.

Whats in this PR:

  • A bulk action to remove personal data from orders manually. When trigger, all data is anonymized.
  • Export integration with https://core.trac.wordpress.org/ticket/43546 which exports customer data, order data, downloads, and download logs.
  • A remove personal data callback. This is not yet hooked into WP UI as it's still unfinished.
  • A foreign key on permission_id/logs so logs are cleaned up when download permissions are removed (@kloon can you see anything wrong with this?)

$personal_data['orders'] = array();
foreach ( $orders as $order ) {
$order_data = array(
'Transaction ID' => $order->get_order_number(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order ID being included here could add context.

Also need to get _billing_address_index meta.

@mikejolley mikejolley added status: in progress This is being worked on. focus: privacy GDPR / Privacy related. labels Mar 9, 2018
@codecov
Copy link

codecov bot commented Mar 14, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@718c91f). Click here to learn what that means.
The diff coverage is 34.96%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #19330   +/-   ##
=========================================
  Coverage          ?   38.65%           
  Complexity        ?    12891           
=========================================
  Files             ?      349           
  Lines             ?    48062           
  Branches          ?        0           
=========================================
  Hits              ?    18577           
  Misses            ?    29485           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
includes/wc-core-functions.php 43.77% <ø> (ø) 0 <0> (?)
...n/list-tables/class-wc-admin-list-table-orders.php 0% <0%> (ø) 109 <0> (?)
includes/class-woocommerce.php 8.93% <0%> (ø) 66 <0> (?)
.../admin/meta-boxes/class-wc-meta-box-order-data.php 0% <0%> (ø) 68 <0> (?)
includes/class-wc-privacy.php 53.09% <53.09%> (ø) 23 <23> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 718c91f...f9e45be. Read the comment docs.

@mikejolley mikejolley self-assigned this Mar 15, 2018
@mikejolley mikejolley changed the title Update/gdpr actions GDPR - Personal data export and removal Apr 13, 2018
@mikejolley mikejolley added this to the 3.4.0 milestone Apr 16, 2018
mikejolley added a commit that referenced this pull request Apr 17, 2018
@mikejolley mikejolley removed the status: in progress This is being worked on. label Apr 17, 2018
Copy link
Contributor

@claudiulodro claudiulodro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and the features work well. I've resolved merge conflicts and am merging this.

@claudiulodro claudiulodro merged commit 5c8adcd into master Apr 17, 2018
@claudiulodro claudiulodro deleted the update/gdpr-actions branch April 17, 2018 20:29
kloon added a commit that referenced this pull request Apr 18, 2018
…d in #19330 the download log needs a valid download to save correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: privacy GDPR / Privacy related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants