Fix gallery thumbnails not opening a lightbox

[mikeyarce]

This commit introduced a bug which prevents gallery thumbnails from opening up in a lightbox: ffbbf08#diff-70e6d5d85f9bbb3126dad3190f865c2f

The commit message is a bit vague but it sounds like the main change was just adding e.preventDefault(); and then there was an else statement added after but not sure why. That else statement is not really needed because it’s not really doing an else, it’s just activating photoswipe for images after that if statement runs.

Removing the else brings back the lightbox for the gallery thumbnails.

[kloon]

@mikeyarce I am testing this on the current master branch and when I disable zoom functionality via add_filter( 'woocommerce_single_product_zoom_enabled', '__return_false' ); it disables it correctly and then still opens up the images in the lightbox.

If you look further atop in that function you will see it already attaches a trigger to the trigger element which is the magnifying class

woocommerce/assets/js/frontend/single-product.js

Line 222 in ffbbf08

this.$target.on( 'click', '.woocommerce-product-gallery__trigger', this.openPhotoswipe );

The gallery images should not open the lightbox when clicked but just load in the main image container, from there you can open them in the lightbox and scroll further.

Which theme have you tested this with?

[mikeyarce]

@kloon I see what you mean. I think the problem is that when the Slider is disabled remove_theme_support( 'wc-product-gallery-slider' ); , then the images below should open up in a lightbox.

Here's Twenty Seventeen with the slider disabled:

Sorry if I didn't specify that! This PR does make sure that this works when the Slider is disabled and opens up the lightbox in that scenario.

[mikejolley]

This might regress the changes made for mobile support so we can just enable conditionally if the slider is disabled.

[mikejolley]

Fix here #20290

Thanks