Allow items to be changed in wc_save_order_items function

[dezio1900]

All Submissions:

• Have you followed the WooCommerce Contributing guideline?
• Does your code follow the WordPress' coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Allow other plugins to be able to change $item object, for example to adjust line subtotal/total before its saved.

My user case for this change is:
Because I have custom booking product item, and attached custom inputs for the item ( checkin / checkout dates etc ). So whenever those inputs are changed in order edit page and ajax save button is triggered, I need to auto adjust booking item's line subtotal/total ( because of booking dates changed ) before item is saved.

Closes #20467 .

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you successfully ran tests with your changes locally?

Changelog entry

[mikejolley]

Is item data and order id needed? Doesn't the item already contain these?

[dezio1900]

Yes, $item already contain these, but usually related data is still passed to filters/actions. For example in add_order_item() function, you can find this filter:

$item    = apply_filters( 'woocommerce_ajax_order_item', $order->get_item( $item_id ), $item_id );

So even if $item has of course its ID, $item_id is still passed to that filter.

[mikejolley]

If it's not necessary I wouldn't include it. If we do need to add args in the future not accessible via $item, this makes it more difficult.

[dezio1900]

Do you think that this would be enough then?

do_action( 'woocommerce_before_save_order_item', $item, $order_id );

[mikejolley]

I don't even think order_id is needed - it's stored within the item.

[kloon]

LGTM