Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/wc blocks/product attribute terms #22809

Merged
merged 3 commits into from Feb 22, 2019

Conversation

timmyc
Copy link
Contributor

@timmyc timmyc commented Feb 21, 2019

All Submissions:

Changes proposed in this Pull Request:

Supersedes #22793

This branch introduces a new REST API namespace for the WooCommerce Blocks functionality: wc-blocks/v1. The first endpoint implemented here is the logic that currently exists in the Woo Blocks plugin for attributes terms wc-blocks/v1/products/attributes/%d/terms

How to test the changes in this Pull Request:

  1. You can use Postman to make requests to wc-blocks/v1/products/attributes/%d/terms
  2. and/or run phpunit tests/unit-tests/api/wc-blocks/products-attributes-terms.php

Other information:

For woocommerce/woocommerce-blocks#426

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Changelog entry

Adds new wc-blocks/v1 endpoint for getting attribute terms for use in Woo Blocks

@timmyc timmyc changed the base branch from add/blocks-rest-api to master February 21, 2019 20:34
@timmyc timmyc mentioned this pull request Feb 21, 2019
6 tasks
Copy link
Contributor

@claudiosanches claudiosanches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small changes.

@timmyc
Copy link
Contributor Author

timmyc commented Feb 21, 2019

Thanks for the review @claudiosanches - added in the updates.

@timmyc timmyc changed the base branch from master to add/blocks-rest-api February 22, 2019 16:08
Copy link
Contributor

@claudiosanches claudiosanches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants