New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/wc blocks/product attribute terms #22809
Merged
timmyc
merged 3 commits into
add/blocks-rest-api
from
add/wc-blocks/product-attribute-terms
Feb 22, 2019
Merged
Add/wc blocks/product attribute terms #22809
timmyc
merged 3 commits into
add/blocks-rest-api
from
add/wc-blocks/product-attribute-terms
Feb 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
claudiosanches
suggested changes
Feb 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some small changes.
includes/api/wc-blocks/class-wc-blocks-rest-product-attribute-terms-controller.php
Outdated
Show resolved
Hide resolved
includes/api/wc-blocks/class-wc-blocks-rest-product-attribute-terms-controller.php
Outdated
Show resolved
Hide resolved
includes/api/wc-blocks/class-wc-blocks-rest-product-attribute-terms-controller.php
Outdated
Show resolved
Hide resolved
Thanks for the review @claudiosanches - added in the updates. |
claudiosanches
approved these changes
Feb 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This was referenced Feb 22, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Supersedes #22793
This branch introduces a new REST API namespace for the WooCommerce Blocks functionality:
wc-blocks/v1
. The first endpoint implemented here is the logic that currently exists in the Woo Blocks plugin for attributes termswc-blocks/v1/products/attributes/%d/terms
How to test the changes in this Pull Request:
wc-blocks/v1/products/attributes/%d/terms
phpunit tests/unit-tests/api/wc-blocks/products-attributes-terms.php
Other information:
For woocommerce/woocommerce-blocks#426
Changelog entry
Adds new
wc-blocks/v1
endpoint for getting attribute terms for use in Woo Blocks