Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show linkout to Marketplace when there are no product metabox suggestions to display #22994

Merged
merged 7 commits into from Mar 14, 2019
Merged

Show linkout to Marketplace when there are no product metabox suggestions to display #22994

merged 7 commits into from Mar 14, 2019

Conversation

haszari
Copy link
Member

@haszari haszari commented Mar 12, 2019 •
edited

Changes proposed in this Pull Request:

When a user has dismissed all the product metabox suggestions, or if there are none to display, the UI is a little confusing.

This PR shows a nice message and button linking to the marketplace so it's clear why it's there.

How to test the changes in this Pull Request:

  1. Clone this branch and get it running as your woocommerce extension in a test environment.
  2. Edit a product, scroll down to metabox, click Get more options tab.
  3. Dismiss all the suggestions – should see nice new UI.

Also, after dismissing all the suggestions, reload the page, and click on the tab.

Screenshots

Screen Shot 2019-03-13 at 9 50 23 AM

@haszari haszari added this to the 3.6.0 milestone Mar 12, 2019
@haszari haszari self-assigned this Mar 12, 2019
kloon
kloon requested changes Mar 12, 2019
View reviewed changes
Copy link
Member

@kloon kloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not getting the same results, in my tests after dismissing all the suggestions it first showed a blank page and then removed the tab for suggestions. Then I reloaded the edit product page for the product and the tab was still missing.

I am in the right branch https://cld.wthms.co/i0DYSJ, here is a screencast after clearing cookies and the user meta

@kloon kloon added needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. and removed status: needs review labels Mar 12, 2019
@haszari
Copy link
Member Author

haszari commented Mar 12, 2019 •
edited

I am in the right branch https://cld.wthms.co/i0DYSJ, here is a screencast after clearing cookies and the user meta

Apologies @kloon – I forgot to push some of this. (😬)

(Thanks for testing the fallback option of hiding everything though.)

@haszari haszari added status: needs review and removed needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. labels Mar 12, 2019
@haszari haszari requested a review from kloon March 12, 2019 20:51
timmyc
timmyc suggested changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@timmyc timmyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing well for me - just the one comment having the two sentences passed through the translate method, and all is looking good here.

includes/admin/marketplace-suggestions/templates/html-product-data-extensions.php Outdated Show resolved Hide resolved
@haszari haszari force-pushed the try/product-metabox-no-suggestions-polish branch from 5367ace to a6ab021 Compare March 13, 2019 01:38
@timmyc
Copy link
Contributor

timmyc commented Mar 13, 2019

Still testing out well for me, thanks for fixing up the translations.

mikejolley
mikejolley previously requested changes Mar 13, 2019
View reviewed changes
Copy link
Member

@mikejolley mikejolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a string missing translation functions. There is also a merge conflict so you may need to regenerate that minified file.

includes/admin/marketplace-suggestions/templates/html-product-data-extensions.php Outdated
<h4><?php esc_html_e( 'Enhance your products', 'woocommerce' ); ?></h4>
<p><?php esc_html_e( 'Extensions can add new functionality to your product pages that make your store stand out', 'woocommerce' ); ?></p>
</div>
<a href="https://woocommerce.com/product-category/woocommerce-extensions/?utm_source=editproduct&amp;utm_campaign=marketplacesuggestions&amp;utm_medium=product" target="blank" class="button">Browse the Marketplace</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This button is not translatable.

@mikejolley mikejolley added needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. and removed status: needs review labels Mar 13, 2019
@haszari haszari force-pushed the try/product-metabox-no-suggestions-polish branch from 898e068 to 7a9d216 Compare March 13, 2019 18:55
@haszari
Copy link
Member Author

haszari commented Mar 13, 2019

All fixed up now @mikejolley. Have rebased onto master & recompiled the js to pick up the upstream changes (hiatus in products list) & tested this is all working correctly.

@haszari haszari requested a review from mikejolley March 13, 2019 18:57
@timmyc timmyc added status: needs review and removed needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. labels Mar 13, 2019
@haszari haszari mentioned this pull request Mar 14, 2019
Merged
@haszari haszari force-pushed the try/product-metabox-no-suggestions-polish branch from 7a9d216 to 657b78a Compare March 14, 2019 02:02
@haszari
Copy link
Member Author

haszari commented Mar 14, 2019

Has been re-rebased and minified js rebuilt to catch the upstream changes (#23025), totally 100% ready for merge :)

kloon
kloon approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@kloon kloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks!

@kloon kloon dismissed mikejolley’s stale review March 14, 2019 07:35

Issue was addressed

@kloon kloon merged commit 8c09e28 into master Mar 14, 2019
@kloon kloon deleted the try/product-metabox-no-suggestions-polish branch March 14, 2019 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmyc timmyc timmyc approved these changes

@kloon kloon kloon approved these changes

@mikejolley mikejolley Awaiting requested review from mikejolley

Assignees

@haszari haszari

Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@haszari @timmyc @mikejolley @kloon @woocommercebot