New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge REST API into core. #27100
Merge REST API into core. #27100
Conversation
@vedanshujain When I have the REST API plugin action (1.1.0) the SSR shows the core REST API as active instead of the plugin. |
Oversight on my part, should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job getting this merged back into Core! I also went a step further and tested the API too and everything seems in order.
It might be worth thinking about where these PSR-4 named files like Server
, Package,
and the Utilities
folder should live. Personally I'd like to refactor them but I think they're probably "public API" and should be treated as such since they were never shipped as anything other than part of Core. With that in mind maybe they should be in src
since they're namespaced? They can be moved later though so there's nothing to worry about for this PR I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It'll be nice to have this merged back to core!
All Submissions:
How to review this PR?
This PR contains all commits from
release/1.0
branch from REST API repo so its not practical to review directly.I would recommend heading over to vedanshujain#2, <- this PR contains changes that are added on top of merging from
release/1.0
to make sure that API works. Edit: There is also a comment below which documents the merge process to preserve original commit author and details.I am planning to target 4.5 for this PR, but an early review and merge would be very much appreciated.
Changes proposed in this Pull Request:
Merge API repo's
release/1.0
into core.How to test the changes in this Pull Request:
From vedanshujain#2:
Other information:
Changelog entry