Fix "Hide shipping costs until an address is entered"

[claudiosanches]

All Submissions:

• Have you followed the WooCommerce Contributing guideline?
• Does your code follow the WordPress' coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Currently by enabling woocommerce_shipping_cost_requires_address will display shipping costs if finds a country or if a state + postcode, what doesn't really reflects what the settings says.

This PR makes woocommerce_shipping_cost_requires_address a little more strict by displaying shipping costs only when a customer enters a country, state and postcode, those are all required information to proper calculate shipping zones and costs.

Closes #26876.

How to test the changes in this Pull Request:

1. Navigate to WooCommerce/Settings/Shipping/Shipping options and select the following checkboxes:

• Hide shipping costs until an address is entered
• Default to customer billing address
• Enable debug mode

2. From a private browser window start a guest cart by placing an item to the cart and observe that the shipping rate is being displayed regardless of the fact that Hide shipping costs until an address is entered is selected. Note that the address may get partially entered by the geolocation option or from the store location:

3. Now apply this patch and update your cart.
4. Not that now shipping costs only get displayed if you have entered country, state and postcode, like for a recurring customer.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully run tests with your changes locally?

Changelog entry

Fix - Fixed the logic behind "Hide shipping costs until an address is entered".

[juliaamosova]

Tested this PR and it works great!

Documenting my experience below:

1. With Hide shipping costs until an address is entered enabled:

There is no shipping calculator on the cart. The shipping charge appears on the Checkout page only when the user enters country, states, and postcode:

2. With both Enable the shipping calculator on the cart page and Hide shipping costs until an address is entered enabled:

There is a link to the shipping calculator on the Cart page as expected. When the user enters the country, state, and the postcode, the shipping charge appears:

Noting that I also tested this with Geolocation enabled and MaxMind integration set up - everything works as expected as described in this PR.

Also unit test ❤️

[jonathansadowski]

Nice job. Looks good to me 👍. Unit tests look good, and the test plan works great.

[Lolosan]

No need for country and state. We get country from geolocation and state is useless with postcode (most accurate)

Asking for 3x customer input, is asking for 3x sanitize, mistakes, correction workload. Let alones, customer UX

After postcode input, in frontend is better to echo "this country, this state, this postcode -> click here to change" instead of "nothing -> click here to work for me"

Will we be able to use postcode alone?