Adding states for Benin(BJ) country 🇧🇯 #27217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added some states from the country : Benin
formating based on phpcs standard
claudiosanches
suggested changes
Aug 4, 2020
i18n/states.php
Outdated
| @@ -172,6 +172,85 @@ | |||
| ), | |||
| 'BH' => array(), | |||
| 'BI' => array(), | |||
| 'BJ' => array( // Benin states. | |||
| 'BJ-01' => __( 'ABOMEY', 'woocommerce' ), | |||
There was a problem hiding this comment.
Those state names doesn't seems to match the list: https://github.com/unicode-org/cldr/blob/master/common/subdivisions/en.xml#L522-L533
Also it's all on uppercase, it need to be fixed.
There was a problem hiding this comment.
Okay i'll apply the changes and commit it
There was a problem hiding this comment.
I have applied changes as mentionned, does it match now?
There was a problem hiding this comment.
claudiosanches
added
the
needs: author feedback
updating by the right states name
rrennick
approved these changes
Aug 14, 2020
rrennick
added
status: needs review
and removed
needs: author feedback
rrennick
reviewed
Aug 14, 2020
i18n/states.php
Outdated
| 'BJ-03' => __( 'Atlantique', 'woocommerce' ), | ||
| 'BJ-04' => __( 'Borgou', 'woocommerce' ), | ||
| 'BJ-05' => __( 'Collines', 'woocommerce' ), | ||
| 'BJ-06' => __( 'Couffo', 'woocommerce' ), |
rrennick
reviewed
Aug 14, 2020
i18n/states.php
Outdated
| @@ -172,6 +172,20 @@ | |||
| ), | |||
| 'BH' => array(), | |||
| 'BI' => array(), | |||
| 'BJ' => array( // Benin states. | |||
| 'BJ-01' => __( 'Alibori', 'woocommerce' ), | |||
| 'BJ-02' => __( 'Atacora', 'woocommerce' ), | |||
There was a problem hiding this comment.
Noting for second reviewer that this is the French spelling for the state.
There was a problem hiding this comment.
Yes, you got a point. This is the French spelling for this state because it is a French state.
claudiosanches
previously requested changes
Sep 4, 2020
Source: https://github.com/unicode-org/cldr/blob/master/common/subdivisions/en.xml#L521 Co-authored-by: Claudio Sanches <contato@claudiosanches.com>
rodrigoprimo
approved these changes
Sep 12, 2020
rodrigoprimo
dismissed
claudiosanches’s stale review
Suggested changes were incorporated
woocommercebot
added
release: add changelog
rodrigoprimo
added
status: approved
and removed
status: needs review
release: add testing instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some states for the Benin country
All Submissions:
Changes proposed in this Pull Request:
These changes add all states for Benin country to the list of WooCommerce Countries. It give the ability to the customers, to pick and select the right states while he is buying on a WooCommerce store.
How to test the changes in this Pull Request:
Changelog entry