Fix error in the sed commands used to prefix namespaces #28038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a minor error in the sed commands used to prefix namespaces in the vendor folder. Due to an extra space sed was considering `.bak` an extra parameter. If we use `-i.bak` instead (without the space), sed creates a backup file which is the desired behavior. With this change we won't be getting the errors below when running `composer install` or `composer update`: ``` Generating autoload files > sh ./bin/prefix-vendor-namespaces.sh Prefixing the appropriate vendor namespaces with Automattic\WooCommerce\Vendor sed: can't read .bak: No such file or directory sed: can't read .bak: No such file or directory sed: can't read .bak: No such file or directory (...) ``` Since sed was working without creating a backup file, I wonder if we really need to create one. I tested and `sed -i -E -e "s/\"(League\\\\\\\Container)/\"Automattic\\\\\\\WooCommerce\\\\\\\Vendor\\\\\\\\\1/g" vendor/league/container/composer.json` works well in Linux. If it also works on Mac, maybe we can use it and remove the code that deletes the .bak files?
claudiosanches
approved these changes
Oct 21, 2020
claudiosanches
deleted the
fix/minor-error-in-prefix-vendor-namespaces
branch
woocommercebot
added
release: add changelog
claudiosanches
removed
release: add changelog
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR fixes a minor error in the sed commands used to prefix namespaces in the vendor folder. Due to an extra space, sed was
considering
.bakan extra parameter. If we use-i.bakinstead (without the space), sed creates a backup file, which is the desired behavior.With this change, we won't be getting the errors below when running
composer installorcomposer update:Since sed was working without creating a backup file, I wonder if we really need to create one. I tested and
sed -i -E -e "s/\"(League\\\\\\\Container)/\"Automattic\\\\\\\WooCommerce\\\\\\\Vendor\\\\\\\\\1/g" vendor/league/container/composer.jsonworks well in Linux. If it also works on Mac, maybe we can use it and remove the code that deletes the .bak files? (cc @Konamiman)How to test the changes in this Pull Request:
composer installorcomposer update, the files invendor/league/containerare correctly prefixed withAutomattic\WooCommerce\Vendorand that you don't get the errors mentioned above.