Also include empty string and comment types for backward compat. #28624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
In #26928, we added
WHERE
clause to only count the reviews which havereview
comment type. However, we also display comments with empty string orcomment
in type column. This means that those reviews are displayed but are not counted.This PR fixes the issue by also counting reviews with empty string or
comment
in the comment type column (since we also display them).This fixes the root cause for #27688, but to close the issue we would need a migration that will correct the review count for existing products.
How to test the changes in this Pull Request:
Note that the counter for review comment is cached in meta value for
product
, so already existing reviews will still not be counted unless the postmeta with meta key_wc_rating_count
for the product is deleted or a new review is added.Other information:
Changelog entry